[PATCH] Add mpty field to ofono_call

[PATCH] Add mpty field to ofono_call

[Zhenhua Zhang]

[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]

A field 'mpty' is added to ofono_call so that we can know
whether the call belongs to multiparty call or not. According
to 27.007 7.18, it is a defined return value of AT+CLCC.
---
 drivers/atmodem/atutil.c |    4 +++-
 include/types.h          |    1 +
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/atmodem/atutil.c b/drivers/atmodem/atutil.c
index 3a365f4..c3d7922 100644
--- a/drivers/atmodem/atutil.c
+++ b/drivers/atmodem/atutil.c
@@ -115,6 +115,7 @@ GSList *at_util_parse_clcc(GAtResult *result)
 	GAtResultIter iter;
 	GSList *l = NULL;
 	int id, dir, status, type;
+	ofono_bool_t mpty;
 	struct ofono_call *call;
 
 	g_at_result_iter_init(&iter, result);
@@ -135,7 +136,7 @@ GSList *at_util_parse_clcc(GAtResult *result)
 		if (!g_at_result_iter_next_number(&iter, &type))
 			continue;
 
-		if (!g_at_result_iter_skip_next(&iter))
+		if (!g_at_result_iter_next_number(&iter, &mpty))
 			continue;
 
 		if (g_at_result_iter_next_string(&iter, &str))
@@ -150,6 +151,7 @@ GSList *at_util_parse_clcc(GAtResult *result)
 		call->direction = dir;
 		call->status = status;
 		call->type = type;
+		call->mpty = mpty;
 		strncpy(call->phone_number.number, str,
 				OFONO_MAX_PHONE_NUMBER_LENGTH);
 		call->phone_number.type = number_type;
diff --git a/include/types.h b/include/types.h
index 6a9681d..79e6d4c 100644
--- a/include/types.h
+++ b/include/types.h
@@ -87,6 +87,7 @@ struct ofono_call {
 	int type;
 	int direction;
 	int status;
+	ofono_bool_t mpty;
 	struct ofono_phone_number phone_number;
 	int clip_validity;
 };
-- 
1.6.2.5

Re: [PATCH] Add mpty field to ofono_call

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

Hi Zhenhua,

> A field 'mpty' is added to ofono_call so that we can know
> whether the call belongs to multiparty call or not. According
> to 27.007 7.18, it is a defined return value of AT+CLCC.
> ---
>  drivers/atmodem/atutil.c |    4 +++-
>  include/types.h          |    1 +
>  2 files changed, 4 insertions(+), 1 deletions(-)

patch has been applied. Thanks.

Regards

Marcel