From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [patch 3/6] LCP support
Date: Wed, 17 Mar 2010 00:09:25 -0700 [thread overview]
Message-ID: <1268809765.2700.104.camel@localhost.localdomain> (raw)
In-Reply-To: <20100316171315.08b8ff09@kcaccard-MOBL3>
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
Hi Kristen,
> Makefile.am | 6 -
> gatchat/gatppp.c | 53 +++++++++
> gatchat/gatppp_internal.h | 8 +
> gatchat/gatppplcp.c | 244 ++++++++++++++++++++++++++++++++++++++++++++++
this should be gatchat/ppp_lcp.c
> +void __ppp_set_auth(GAtPPP *ppp, guint8* auth_data)
> +{
> + guint16 proto = ntohs(*(guint16 *)auth_data);
This are again one of these constructs that will break on non-x86
hardware.
I think you need to create ppp_get_unaligned and ppp_put_unaligned. If
all of them are be16 anyway, you could do ppp_get_unaligned_be16 etc.
Regards
Marcel
next prev parent reply other threads:[~2010-03-17 7:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100317000824.420232401@linux.intel.com>
2010-03-17 0:13 ` [patch 1/6] Add PPP protocol support with HDLC framing Kristen Carlson Accardi
2010-03-17 6:28 ` Marcel Holtmann
2010-03-17 0:13 ` [patch 2/6] Generic PPP control protocol Kristen Carlson Accardi
2010-03-17 7:06 ` Marcel Holtmann
2010-03-18 23:03 ` Kristen Carlson Accardi
2010-03-19 3:57 ` Marcel Holtmann
2010-03-17 0:13 ` [patch 3/6] LCP support Kristen Carlson Accardi
2010-03-17 7:09 ` Marcel Holtmann [this message]
2010-03-17 18:59 ` Kristen Carlson Accardi
2010-03-17 19:31 ` Marcel Holtmann
2010-03-17 0:13 ` [patch 4/6] CHAP with MD5 authentication Kristen Carlson Accardi
2010-03-17 7:12 ` Marcel Holtmann
2010-03-17 0:13 ` [patch 5/6] IP support for PPP Kristen Carlson Accardi
2010-03-17 6:38 ` Marcel Holtmann
2010-03-18 0:12 ` Kristen Carlson Accardi
2010-03-18 11:26 ` Marcel Holtmann
2010-03-19 17:58 ` Kristen Carlson Accardi
2010-03-17 0:13 ` [patch 6/6] Allow gsmdial to use gatchat ppp support Kristen Carlson Accardi
2010-03-17 6:42 ` Marcel Holtmann
[not found] <20100319194705.214150215@linux.intel.com>
2010-03-19 19:46 ` [patch 3/6] LCP support Kristen Carlson Accardi
[not found] <20100311214022.838696145@linux.intel.com>
2010-03-11 22:00 ` kristen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268809765.2700.104.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox