From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [patch 2/6] Generic PPP control protocol
Date: Fri, 19 Mar 2010 04:57:05 +0100 [thread overview]
Message-ID: <1268971025.3003.2.camel@violet> (raw)
In-Reply-To: <20100318160357.777b3ee7@kcaccard-MOBL3>
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
Hi Kristen,
> > > +struct pppcp_data;
> >
> > Why is this needed?
>
> this is needed because we have some circular dependencies in the
> pppcp_data structure and the pppcp_actions structure.
you might be absolutely right that this is needed. And it is cleanest
way to do it. However every time I see forward declarations and hear
circular dependencies, I question if the code might not be too complex.
Please keep this in mind. We will revisit this again when doing a deep
down dive review after the merge.
Regards
Marcel
next prev parent reply other threads:[~2010-03-19 3:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100317000824.420232401@linux.intel.com>
2010-03-17 0:13 ` [patch 1/6] Add PPP protocol support with HDLC framing Kristen Carlson Accardi
2010-03-17 6:28 ` Marcel Holtmann
2010-03-17 0:13 ` [patch 2/6] Generic PPP control protocol Kristen Carlson Accardi
2010-03-17 7:06 ` Marcel Holtmann
2010-03-18 23:03 ` Kristen Carlson Accardi
2010-03-19 3:57 ` Marcel Holtmann [this message]
2010-03-17 0:13 ` [patch 3/6] LCP support Kristen Carlson Accardi
2010-03-17 7:09 ` Marcel Holtmann
2010-03-17 18:59 ` Kristen Carlson Accardi
2010-03-17 19:31 ` Marcel Holtmann
2010-03-17 0:13 ` [patch 4/6] CHAP with MD5 authentication Kristen Carlson Accardi
2010-03-17 7:12 ` Marcel Holtmann
2010-03-17 0:13 ` [patch 5/6] IP support for PPP Kristen Carlson Accardi
2010-03-17 6:38 ` Marcel Holtmann
2010-03-18 0:12 ` Kristen Carlson Accardi
2010-03-18 11:26 ` Marcel Holtmann
2010-03-19 17:58 ` Kristen Carlson Accardi
2010-03-17 0:13 ` [patch 6/6] Allow gsmdial to use gatchat ppp support Kristen Carlson Accardi
2010-03-17 6:42 ` Marcel Holtmann
[not found] <20100319194705.214150215@linux.intel.com>
2010-03-19 19:46 ` [patch 2/6] Generic PPP control protocol Kristen Carlson Accardi
[not found] <20100311214022.838696145@linux.intel.com>
2010-03-11 22:00 ` kristen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268971025.3003.2.camel@violet \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox