From: Kristen Carlson Accardi <kristen@linux.intel.com>
To: ofono@ofono.org
Subject: [PATCH 2/5] ppp: comment fix
Date: Fri, 26 Mar 2010 18:34:27 -0700 [thread overview]
Message-ID: <1269653670-31352-3-git-send-email-kristen@linux.intel.com> (raw)
In-Reply-To: <1269653670-31352-1-git-send-email-kristen@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]
Put some additional clarification in comment for receiving Code-Reject
and Protocol-Reject packets.
---
gatchat/ppp_cp.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c
index 39e872b..f83cfba 100644
--- a/gatchat/ppp_cp.c
+++ b/gatchat/ppp_cp.c
@@ -1401,6 +1401,10 @@ static guint8 pppcp_process_code_reject(struct pppcp_data *data,
* determine if the code reject is catastrophic or not.
* return RXJ_PLUS if this reject is acceptable, RXJ_MINUS if
* it is catastrophic.
+ *
+ * for now we always return RXJ_MINUS. Any code
+ * reject will be catastrophic, since we only support the
+ * bare minimum number of codes necessary to function.
*/
return RXJ_MINUS;
}
@@ -1412,6 +1416,10 @@ static guint8 pppcp_process_protocol_reject(struct pppcp_data *data,
* determine if the protocol reject is catastrophic or not.
* return RXJ_PLUS if this reject is acceptable, RXJ_MINUS if
* it is catastrophic.
+ *
+ * for now we always return RXJ_MINUS. Any protocol
+ * reject will be catastrophic, since we only support the
+ * bare minimum number of protocols necessary to function.
*/
return RXJ_MINUS;
}
--
1.6.6.1
next prev parent reply other threads:[~2010-03-27 1:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-27 1:34 [PATCH 0/5] ppp: error path fixes Kristen Carlson Accardi
2010-03-27 1:34 ` [PATCH 1/5] ppp: fix segfault in pppcp_send_code_reject() Kristen Carlson Accardi
2010-03-27 1:34 ` Kristen Carlson Accardi [this message]
2010-03-27 1:34 ` [PATCH 3/5] ppp: send Protocol-Reject Kristen Carlson Accardi
2010-03-27 1:34 ` [PATCH 4/5] ppp: use common code to get options from pppcp packet data Kristen Carlson Accardi
2010-03-27 1:34 ` [PATCH 5/5] ppp: handle Config-Reject Kristen Carlson Accardi
2010-03-27 2:29 ` [PATCH 0/5] ppp: error path fixes Marcel Holtmann
2010-03-27 4:39 ` Kristen Carlson Accardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269653670-31352-3-git-send-email-kristen@linux.intel.com \
--to=kristen@linux.intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox