Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 0/5] ppp: error path fixes
Date: Fri, 26 Mar 2010 19:29:00 -0700	[thread overview]
Message-ID: <1269656940.11714.190.camel@localhost.localdomain> (raw)
In-Reply-To: <1269653670-31352-1-git-send-email-kristen@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

Hi Kristen,

> Here are some patches which fix some issues with the error paths in
> the PPP control protocol code.
> 
> Kristen Carlson Accardi (5):
>   ppp: fix segfault in pppcp_send_code_reject()
>   ppp: comment fix
>   ppp: send Protocol-Reject
>   ppp: use common code to get options from pppcp packet data
>   ppp: handle Config-Reject
> 
>  gatchat/ppp.c     |   29 ++++++---
>  gatchat/ppp.h     |    1 +
>  gatchat/ppp_cp.c  |  179 +++++++++++++++++++++++++++++++++++++++-------------
>  gatchat/ppp_cp.h  |    2 +
>  gatchat/ppp_lcp.c |    5 ++
>  5 files changed, 161 insertions(+), 55 deletions(-)

all five patches have been applied.

Also I pushed the support for NBNS options upstream. With these changes
I don't see the endless loop anymore.

Problem is still that we can't leave the CHAP secrets empty. For
networks where the username and password are not in use, we should be
able to leave them empty.

Regards

Marcel



  parent reply	other threads:[~2010-03-27  2:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-27  1:34 [PATCH 0/5] ppp: error path fixes Kristen Carlson Accardi
2010-03-27  1:34 ` [PATCH 1/5] ppp: fix segfault in pppcp_send_code_reject() Kristen Carlson Accardi
2010-03-27  1:34 ` [PATCH 2/5] ppp: comment fix Kristen Carlson Accardi
2010-03-27  1:34 ` [PATCH 3/5] ppp: send Protocol-Reject Kristen Carlson Accardi
2010-03-27  1:34 ` [PATCH 4/5] ppp: use common code to get options from pppcp packet data Kristen Carlson Accardi
2010-03-27  1:34 ` [PATCH 5/5] ppp: handle Config-Reject Kristen Carlson Accardi
2010-03-27  2:29 ` Marcel Holtmann [this message]
2010-03-27  4:39   ` [PATCH 0/5] ppp: error path fixes Kristen Carlson Accardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269656940.11714.190.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox