[PATCH] Fix: use of g_checksum_get_digest() inout argument

[PATCH] Fix: use of g_checksum_get_digest() inout argument

[ppessi]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

From: Pekka Pessi <Pekka.Pessi@nokia.com>

---
 gatchat/ppp_auth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gatchat/ppp_auth.c b/gatchat/ppp_auth.c
index fe3c501..1e0c82b 100644
--- a/gatchat/ppp_auth.c
+++ b/gatchat/ppp_auth.c
@@ -107,7 +107,7 @@ static void chap_process_challenge(struct auth_data *auth, guint8 *packet)
 		response->length = htons(response_length);
 		response->data[0] = digest_len;
 		g_checksum_get_digest(checksum, &response->data[1],
-					(gsize *) &response->data[0]);
+					&digest_len);
 		/* leave the name empty? */
 	}
 
-- 
1.6.3.3

Re: [PATCH] Fix: use of g_checksum_get_digest() inout argument

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]

Hi Pekka,

>  gatchat/ppp_auth.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/gatchat/ppp_auth.c b/gatchat/ppp_auth.c
> index fe3c501..1e0c82b 100644
> --- a/gatchat/ppp_auth.c
> +++ b/gatchat/ppp_auth.c
> @@ -107,7 +107,7 @@ static void chap_process_challenge(struct auth_data *auth, guint8 *packet)
>  		response->length = htons(response_length);
>  		response->data[0] = digest_len;
>  		g_checksum_get_digest(checksum, &response->data[1],
> -					(gsize *) &response->data[0]);
> +					&digest_len);
>  		/* leave the name empty? */
>  	}

thanks for the patch. I changed it a bit by moving the data[0]
assignment after the get_digest call to ensure we use the right length
value on the wire. Not that it matters in this case since it is a fixed
length anyway, but just in case.

Regards

Marcel