From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 1/3] hdlc: allow for scanning and escaping
Date: Sat, 17 Apr 2010 15:34:14 -0700 [thread overview]
Message-ID: <1271543654.22838.28.camel@localhost.localdomain> (raw)
In-Reply-To: <1271528135-12337-2-git-send-email-kristen@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
Hi Kristen,
> PPP needs to inspect the packet protocol to see if a character
> should be escaped. Additionally, it needs to be able to compare
> against recv and xmit accm.
can we just set the ACCM values instead of having an extra function
call. I think that calling an extra function for every single byte is a
really bad idea and the compiler can not optimize it at all.
Regards
Marcel
next prev parent reply other threads:[~2010-04-17 22:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-17 18:15 [PATCH 0/3] HDLC fixes Kristen Carlson Accardi
2010-04-17 18:15 ` [PATCH 1/3] hdlc: allow for scanning and escaping Kristen Carlson Accardi
2010-04-17 22:34 ` Marcel Holtmann [this message]
2010-04-17 18:15 ` [PATCH 2/3] hdlc: handle wrapped buffers Kristen Carlson Accardi
2010-04-17 22:39 ` Marcel Holtmann
2010-04-27 3:02 ` Marcel Holtmann
2010-04-17 18:15 ` [PATCH 3/3] ppp: use GAtHDLC Kristen Carlson Accardi
2010-04-17 22:36 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271543654.22838.28.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox