Re: [PATCH 3/3] ppp: use GAtHDLC

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

Hi Kristen,

> +static void ppp_record(GAtPPP *ppp, gboolean in, guint8 *data, guint16 length)
> +{
> +	guint16 len = htons(length);
> +	guint32 ts;
> +	struct timeval now;
> +	unsigned char id;
> +	int err;
> +
> +	if (ppp->record_fd < 0)
> +		return;
> +
> +	gettimeofday(&now, NULL);
> +	ts = htonl(now.tv_sec & 0xffffffff);
> +
> +	id = 0x07;
> +	err = write(ppp->record_fd, &id, 1);
> +	err = write(ppp->record_fd, &ts, 4);
> +
> +	id = in ? 0x02 : 0x01;
> +	err = write(ppp->record_fd, &id, 1);
> +	err = write(ppp->record_fd, &len, 2);
> +	err = write(ppp->record_fd, data, length);
> +}
> +

there is one change that has to happen first here. We need to add
g_at_hdlc_set_recording. And this needs to take a file name and an
actual format parameter. With pppdump being the initial format.

Then the g_at_ppp_set_recoding can just call the HDLC recording function
and set this. I do wanna have this in a central place. And at the same
time allow recording of other HDLC based data formats that Wireshark
eventually can support.

Regards

Marcel