Re: [PATCH v2 1/6] atmodem: create struct atmodem_gprs

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 967 bytes --]

Hi Kalle,

> This is need to to provide more chat channels to atmodem gprs module.
> ---
> 
>  drivers/atmodem/gprs.c |    7 ++++---
>  drivers/atmodem/gprs.h |   29 +++++++++++++++++++++++++++++
>  plugins/hso.c          |    8 +++++++-
>  plugins/mbm.c          |    7 ++++++-
>  plugins/palmpre.c      |    8 +++++++-
>  plugins/phonesim.c     |    7 ++++++-
>  plugins/ste.c          |    7 ++++++-
>  7 files changed, 65 insertions(+), 8 deletions(-)
>  create mode 100644 drivers/atmodem/gprs.h

I don't really like this. You only need to catch the CGREG anyway so we
might just wanna add some indication method. Similar to what we have for
network registration with ofono_netreg_status_notify.

Then the messed up CGREG from Huawei modem doesn't dictate the whole
simple one GAtChat approach. It is really their fault with no sending
these on the proper AT command channel. No need to make other drivers
suffer.

Regards

Marcel