Open Source Telephony
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@canonical.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2 1/6] atmodem: create struct atmodem_gprs
Date: Mon, 03 May 2010 09:39:46 +0300	[thread overview]
Message-ID: <87iq75a3pp.fsf@potku.valot.fi> (raw)
In-Reply-To: <1272634482.22838.193.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

Marcel Holtmann <marcel@holtmann.org> writes:

> Hi Kalle,

Hi Marcel,

> I don't really like this. You only need to catch the CGREG anyway so we
> might just wanna add some indication method. Similar to what we have for
> network registration with ofono_netreg_status_notify.
>
> Then the messed up CGREG from Huawei modem doesn't dictate the whole
> simple one GAtChat approach. It is really their fault with no sending
> these on the proper AT command channel. No need to make other drivers
> suffer.

Sounds very good to me. I didn't even think about this because I was
under (false) impression that all AT commands must be handled in atmodem
driver.

I'm travelling the next two weeks, so it might take a while before I
have v3 ready.

-- 
Kalle Valo

  reply	other threads:[~2010-05-03  6:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-30 12:54 [PATCH v2 0/6] Huawei GPRS support Kalle Valo
2010-04-30 12:54 ` [PATCH v2 1/6] atmodem: create struct atmodem_gprs Kalle Valo
2010-04-30 13:34   ` Marcel Holtmann
2010-05-03  6:39     ` Kalle Valo [this message]
2010-04-30 12:55 ` [PATCH v2 2/6] atmodem: create struct atmodem_network_registration Kalle Valo
2010-04-30 13:35   ` Marcel Holtmann
2010-04-30 12:55 ` [PATCH v2 3/6] huawei: detect SecondaryDevice which is used for events Kalle Valo
2010-04-30 12:55 ` [PATCH v2 4/6] atmodem: follow separate event chat with huawei Kalle Valo
2010-04-30 12:55 ` [PATCH v2 5/6] atmodem: add signal strength support for huawei Kalle Valo
2010-04-30 13:38   ` Marcel Holtmann
2010-05-03  6:43     ` Kalle Valo
2010-04-30 12:55 ` [PATCH v2 6/6] huawei: add gprs context Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iq75a3pp.fsf@potku.valot.fi \
    --to=kalle.valo@canonical.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox