From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 1/6] Add bluetooth plugin skeleton.
Date: Mon, 31 May 2010 08:51:21 -0700 [thread overview]
Message-ID: <1275321081.2658.8.camel@localhost.localdomain> (raw)
In-Reply-To: <87pr0c2sel.fsf@potku.valot.fi>
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
Hi Kalle,
> >> +#ifndef __BLUETOOTH_H
> >> +#define __BLUETOOTH_H
> >
> > No ifdef guards please.
>
> I'm curious, why not?
the ifdef guards are only needed for public exposed include files to
protect against circular inclusion.
For local headers I do want it fail if anybody attempts a circular
inclusion. If they are needed, then it is a good sign that something is
way too complex.
Regards
Marcel
next prev parent reply other threads:[~2010-05-31 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 4:51 [PATCH 1/6] Add bluetooth plugin skeleton Gustavo F. Padovan
2010-05-26 4:51 ` [PATCH 2/6] Move bluetooth utils from hfp.c to bluetooth.c Gustavo F. Padovan
2010-05-26 4:51 ` [PATCH 3/6] Remove send_method_call from hfp.c Gustavo F. Padovan
2010-05-26 4:51 ` [PATCH 4/6] Move create_path() to bluetooth plugin Gustavo F. Padovan
2010-05-26 4:51 ` [PATCH 5/6] Change hfpmodem's header define Gustavo F. Padovan
2010-05-26 4:51 ` [PATCH 6/6] Bluetooth DUN modem prototype Gustavo F. Padovan
2010-05-28 14:19 ` Denis Kenzior
2010-05-28 14:13 ` [PATCH 5/6] Change hfpmodem's header define Denis Kenzior
2010-05-28 14:11 ` [PATCH 1/6] Add bluetooth plugin skeleton Denis Kenzior
2010-05-31 11:59 ` Kalle Valo
2010-05-31 15:51 ` Marcel Holtmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-05-17 2:11 Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275321081.2658.8.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox