Open Source Telephony
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@canonical.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/6] Add bluetooth plugin skeleton.
Date: Mon, 31 May 2010 14:59:46 +0300	[thread overview]
Message-ID: <87pr0c2sel.fsf@potku.valot.fi> (raw)
In-Reply-To: <201005280911.44961.denkenz@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

Denis Kenzior <denkenz@gmail.com> writes:

> Hi Gustavo,

Hi Denis,

>> +#ifndef __BLUETOOTH_H
>> +#define __BLUETOOTH_H
>
> No ifdef guards please.

I'm curious, why not?

-- 
Kalle Valo

  reply	other threads:[~2010-05-31 11:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-26  4:51 [PATCH 1/6] Add bluetooth plugin skeleton Gustavo F. Padovan
2010-05-26  4:51 ` [PATCH 2/6] Move bluetooth utils from hfp.c to bluetooth.c Gustavo F. Padovan
2010-05-26  4:51   ` [PATCH 3/6] Remove send_method_call from hfp.c Gustavo F. Padovan
2010-05-26  4:51     ` [PATCH 4/6] Move create_path() to bluetooth plugin Gustavo F. Padovan
2010-05-26  4:51       ` [PATCH 5/6] Change hfpmodem's header define Gustavo F. Padovan
2010-05-26  4:51         ` [PATCH 6/6] Bluetooth DUN modem prototype Gustavo F. Padovan
2010-05-28 14:19           ` Denis Kenzior
2010-05-28 14:13         ` [PATCH 5/6] Change hfpmodem's header define Denis Kenzior
2010-05-28 14:11 ` [PATCH 1/6] Add bluetooth plugin skeleton Denis Kenzior
2010-05-31 11:59   ` Kalle Valo [this message]
2010-05-31 15:51     ` Marcel Holtmann
  -- strict thread matches above, loose matches on Subject: below --
2010-05-17  2:11 Gustavo F. Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pr0c2sel.fsf@potku.valot.fi \
    --to=kalle.valo@canonical.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox