Open Source Telephony
 help / color / mirror / Atom feed
From: Andrzej Zaborowski <andrew.zaborowski@intel.com>
To: ofono@ofono.org
Subject: [PATCH 10/20] Add a "sim string" encoding utility.
Date: Mon, 07 Jun 2010 12:08:32 +0200	[thread overview]
Message-ID: <1275905322-14768-10-git-send-email-andrew.zaborowski@intel.com> (raw)
In-Reply-To: <1275905322-14768-1-git-send-email-andrew.zaborowski@intel.com>

[-- Attachment #1: Type: text/plain, Size: 3081 bytes --]

---
 src/simutil.c |   25 ++++++++++---------------
 src/util.c    |   46 ++++++++++++++++++++++++++++++++++++++++++++++
 src/util.h    |    3 +++
 3 files changed, 59 insertions(+), 15 deletions(-)

diff --git a/src/simutil.c b/src/simutil.c
index f980bf6..7291729 100644
--- a/src/simutil.c
+++ b/src/simutil.c
@@ -1232,29 +1232,24 @@ void sim_adn_build(unsigned char *data, int length,
 			const char *identifier)
 {
 	int number_len = strlen(ph->number);
-	unsigned char *gsm_identifier = NULL;
-	long gsm_bytes;
-	long alpha_length;
+	unsigned char *alpha = NULL;
+	int alpha_written = 0;
+	int alpha_length;
 
 	alpha_length = length - 14;
 
 	/* Alpha-Identifier field */
 	if (alpha_length > 0) {
-		memset(data, 0xff, alpha_length);
-
 		if (identifier)
-			gsm_identifier = convert_utf8_to_gsm(identifier,
-					-1, NULL, &gsm_bytes, 0);
-
-		if (gsm_identifier) {
-			memcpy(data, gsm_identifier,
-				MIN(gsm_bytes, alpha_length));
-			g_free(gsm_identifier);
+			alpha = utf8_to_sim_string(identifier, alpha_length,
+							&alpha_written);
+		if (alpha) {
+			memcpy(data, alpha, alpha_written);
+			g_free(alpha);
 		}
 
-		/* TODO: figure out when the identifier needs to
-		 * be encoded in UCS2 and do this.
-		 */
+		memset(data + alpha_written, 0xff,
+				alpha_length - alpha_written);
 		data += alpha_length;
 	}
 
diff --git a/src/util.c b/src/util.c
index e5ce7b3..fd8b305 100644
--- a/src/util.c
+++ b/src/util.c
@@ -1215,3 +1215,49 @@ char *sim_string_to_utf8(const unsigned char *buffer, int length)
 
 	return utf8;
 }
+
+unsigned char *utf8_to_sim_string(const char *utf,
+					int max_length, int *out_length)
+{
+	unsigned char *result;
+	unsigned char *ucs2;
+	long gsm_bytes;
+	gsize converted;
+
+	result = convert_utf8_to_gsm(utf, -1, NULL, &gsm_bytes, 0);
+	if (result) {
+		if (gsm_bytes > max_length) {
+			gsm_bytes = max_length;
+			while (gsm_bytes && result[gsm_bytes - 1] == 0x1b)
+				gsm_bytes -= 1;
+		}
+
+		*out_length = gsm_bytes;
+		return result;
+	}
+
+	/* NOTE: UCS2 formats with an offset are never used */
+
+	ucs2 = (guint8 *) g_convert(utf, -1, "UCS-2BE//TRANSLIT", "UTF-8",
+					NULL, &converted, NULL);
+
+	if (!ucs2)
+		return NULL;
+
+	if (max_length != -1 && (int) converted + 1 > max_length)
+		converted = (max_length - 1) & ~1;
+
+	result = g_try_malloc(converted + 1);
+	if (!result) {
+		g_free(ucs2);
+		return NULL;
+	}
+
+	*out_length = converted + 1;
+
+	result[0] = 0x80;
+	memcpy(&result[1], ucs2, converted);
+	g_free(ucs2);
+
+	return result;
+}
diff --git a/src/util.h b/src/util.h
index 2835b76..9da81aa 100644
--- a/src/util.h
+++ b/src/util.h
@@ -77,3 +77,6 @@ unsigned char *pack_7bit(const unsigned char *in, long len, int byte_offset,
 				long *items_written, unsigned char terminator);
 
 char *sim_string_to_utf8(const unsigned char *buffer, int length);
+
+unsigned char *utf8_to_sim_string(const char *utf,
+					int max_length, int *out_length);
-- 
1.7.1.86.g0e460.dirty


  parent reply	other threads:[~2010-06-07 10:08 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-07 10:08 [PATCH 01/20] Make stk_pdu_from_response use static buffers Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 02/20] stkutil: Add SMS-PP Data Download envelope builder Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 03/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 04/20] stkutil: Add CBS-PP " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 05/20] stk: Use envelope encoding utility from stkutil.c Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 06/20] Fix: download CBS to SIM even when "Powered" is 0 Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 07/20] test-stkutil: Tests for CBS-PP Data Download envelope builder Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 08/20] stkutil: Add the Menu Selection " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 09/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` Andrzej Zaborowski [this message]
2010-06-07 10:08 ` [PATCH 11/20] simutil: Fix MMC MNC encoding for 2-digit MNCs Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 12/20] stkutil: Add the Call Control envelope builder Andrzej Zaborowski
2010-06-09 22:57   ` Denis Kenzior
2010-06-11 19:18     ` Andrzej Zaborowski
2010-06-11 19:34       ` Denis Kenzior
2010-06-11 20:04         ` Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 13/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 14/20] stkutil: Add the MO Short Message " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 15/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 16/20] For unitialised stk_location_info emit no data object Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 17/20] stkutil: Add the Event Download envelope builder Andrzej Zaborowski
2010-06-10  1:06   ` Denis Kenzior
2010-06-10  1:19     ` Marcel Holtmann
2010-06-10  1:37       ` Denis Kenzior
2010-06-11 19:27     ` Andrzej Zaborowski
2010-06-11 19:31       ` Denis Kenzior
2010-06-07 10:08 ` [PATCH 18/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 19/20] stkutil: Add the Timer Expiration " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 20/20] test-stkutil: Tests for " Andrzej Zaborowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275905322-14768-10-git-send-email-andrew.zaborowski@intel.com \
    --to=andrew.zaborowski@intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox