From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 17/20] stkutil: Add the Event Download envelope builder
Date: Fri, 11 Jun 2010 14:31:39 -0500 [thread overview]
Message-ID: <201006111431.40078.denkenz@gmail.com> (raw)
In-Reply-To: <AANLkTimppyAsTK346PXxtdlRG0JF2DwvU-yMuKPLXxti@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
Hi Andrew,
> Hi,
>
> On 10 June 2010 03:06, Denis Kenzior <denkenz@gmail.com> wrote:
> > Hi Andrew,
> >
> >> /* Network Byte Order */
> >> - unsigned int ipv4;
> >> + guint32 ipv4;
> >
> > Why?
>
> int has no guranteed size except at the ABI level. So the SysV r4
> ABIs for x86, ARM and amd64 make it 32-bit but you don't know what
> happens elsewhere. I'll remove this change as it's unlikely int will
> be < 32-bit and if it's wider we don't care. (I, too, prefer stdint
> types like uint32_t).
Lets go with uint32_t, I think everyone agrees it the better approach.
Regards,
-Denis
next prev parent reply other threads:[~2010-06-11 19:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 10:08 [PATCH 01/20] Make stk_pdu_from_response use static buffers Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 02/20] stkutil: Add SMS-PP Data Download envelope builder Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 03/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 04/20] stkutil: Add CBS-PP " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 05/20] stk: Use envelope encoding utility from stkutil.c Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 06/20] Fix: download CBS to SIM even when "Powered" is 0 Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 07/20] test-stkutil: Tests for CBS-PP Data Download envelope builder Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 08/20] stkutil: Add the Menu Selection " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 09/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 10/20] Add a "sim string" encoding utility Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 11/20] simutil: Fix MMC MNC encoding for 2-digit MNCs Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 12/20] stkutil: Add the Call Control envelope builder Andrzej Zaborowski
2010-06-09 22:57 ` Denis Kenzior
2010-06-11 19:18 ` Andrzej Zaborowski
2010-06-11 19:34 ` Denis Kenzior
2010-06-11 20:04 ` Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 13/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 14/20] stkutil: Add the MO Short Message " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 15/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 16/20] For unitialised stk_location_info emit no data object Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 17/20] stkutil: Add the Event Download envelope builder Andrzej Zaborowski
2010-06-10 1:06 ` Denis Kenzior
2010-06-10 1:19 ` Marcel Holtmann
2010-06-10 1:37 ` Denis Kenzior
2010-06-11 19:27 ` Andrzej Zaborowski
2010-06-11 19:31 ` Denis Kenzior [this message]
2010-06-07 10:08 ` [PATCH 18/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 19/20] stkutil: Add the Timer Expiration " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 20/20] test-stkutil: Tests for " Andrzej Zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006111431.40078.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox