* [PATCH] test-server: Refactor set_raw_mode
@ 2010-07-07 0:42 Zhenhua Zhang
2010-07-07 1:31 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Zhenhua Zhang @ 2010-07-07 0:42 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
Rename variable 'options' to 'ti' and use sizeof(ti).
---
gatchat/test-server.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/gatchat/test-server.c b/gatchat/test-server.c
index 2911978..49012dc 100644
--- a/gatchat/test-server.c
+++ b/gatchat/test-server.c
@@ -846,13 +846,13 @@ static void server_destroy(gpointer user)
static void set_raw_mode(int fd)
{
- struct termios options;
+ struct termios ti;
- memset(&options, 0, sizeof(struct termios));
- tcgetattr(fd, &options);
+ memset(&ti, 0, sizeof(ti));
+ tcgetattr(fd, &ti);
tcflush(fd, TCIOFLUSH);
- cfmakeraw(&options);
- tcsetattr(fd, TCSANOW, &options);
+ cfmakeraw(&ti);
+ tcsetattr(fd, TCSANOW, &ti);
}
static gboolean create_tty(const char *modem_path)
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] test-server: Refactor set_raw_mode
2010-07-07 0:42 [PATCH] test-server: Refactor set_raw_mode Zhenhua Zhang
@ 2010-07-07 1:31 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2010-07-07 1:31 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 236 bytes --]
Hi Zhenhua,
> Rename variable 'options' to 'ti' and use sizeof(ti).
> ---
> gatchat/test-server.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-07 1:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-07 0:42 [PATCH] test-server: Refactor set_raw_mode Zhenhua Zhang
2010-07-07 1:31 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox