Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 1/2] add cdma radio setting
Date: Mon, 23 Aug 2010 13:22:04 +0200	[thread overview]
Message-ID: <1282562524.23399.237.camel@localhost.localdomain> (raw)
In-Reply-To: <1282560341-2486-1-git-send-email-caiwenzhang@163.com>

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

Hi Caiwen,

> ---
>  include/radio-settings.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 include/radio-settings.h

please stop sending these patches until you have configured GIT
correctly.

I haven't even looked at the content of these patches yet, but the GIT
user.name and user.email are setting are wrong. And you need to figure
out your filesystem details. I am not going to look at any patches that
arbitrarily changing modes of files.

If a mode change is required it needs to be explained in the commit
message.

Regards

Marcel



  reply	other threads:[~2010-08-23 11:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-23 10:45 [PATCH 1/2] add cdma radio setting caiwen.zhang
2010-08-23 11:22 ` Marcel Holtmann [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-08-23  6:36 caiwenzhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282562524.23399.237.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox