Open Source Telephony
 help / color / mirror / Atom feed
* [PATCH 1/2] add cdma radio setting
@ 2010-08-23  6:36 caiwenzhang
  0 siblings, 0 replies; 3+ messages in thread
From: caiwenzhang @ 2010-08-23  6:36 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

From: caiwen.zhang <cwzhang@cwzhang-laptop.(none)>

---
 include/radio-settings.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 include/radio-settings.h

diff --git a/include/radio-settings.h b/include/radio-settings.h
old mode 100644
new mode 100755
index d41ec0b..59b86c1
--- a/include/radio-settings.h
+++ b/include/radio-settings.h
@@ -33,6 +33,10 @@ enum ofono_radio_access_mode {
 	OFONO_RADIO_ACCESS_MODE_GSM	= 1,
 	OFONO_RADIO_ACCESS_MODE_UMTS	= 2,
 	OFONO_RADIO_ACCESS_MODE_LTE	= 3,
+
+	OFONO_CDMA_RADIO_ACCESS_MODE_CDMA = 4,
+	OFONO_CDMA_RADIO_ACCESS_MODE_HDR = 5,
+	OFONO_CDMA_RADIO_ACCESS_MODE_HYBRID = 6,  /* CDMA/HDR HYBRID */
 };
 
 struct ofono_radio_settings;
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 1/2] add cdma radio setting
@ 2010-08-23 10:45 caiwen.zhang
  2010-08-23 11:22 ` Marcel Holtmann
  0 siblings, 1 reply; 3+ messages in thread
From: caiwen.zhang @ 2010-08-23 10:45 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

---
 include/radio-settings.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 include/radio-settings.h

diff --git a/include/radio-settings.h b/include/radio-settings.h
old mode 100644
new mode 100755
index d41ec0b..59b86c1
--- a/include/radio-settings.h
+++ b/include/radio-settings.h
@@ -33,6 +33,10 @@ enum ofono_radio_access_mode {
 	OFONO_RADIO_ACCESS_MODE_GSM	= 1,
 	OFONO_RADIO_ACCESS_MODE_UMTS	= 2,
 	OFONO_RADIO_ACCESS_MODE_LTE	= 3,
+
+	OFONO_CDMA_RADIO_ACCESS_MODE_CDMA = 4,
+	OFONO_CDMA_RADIO_ACCESS_MODE_HDR = 5,
+	OFONO_CDMA_RADIO_ACCESS_MODE_HYBRID = 6,  /* CDMA/HDR HYBRID */
 };
 
 struct ofono_radio_settings;
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] add cdma radio setting
  2010-08-23 10:45 [PATCH 1/2] add cdma radio setting caiwen.zhang
@ 2010-08-23 11:22 ` Marcel Holtmann
  0 siblings, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2010-08-23 11:22 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

Hi Caiwen,

> ---
>  include/radio-settings.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 include/radio-settings.h

please stop sending these patches until you have configured GIT
correctly.

I haven't even looked at the content of these patches yet, but the GIT
user.name and user.email are setting are wrong. And you need to figure
out your filesystem details. I am not going to look at any patches that
arbitrarily changing modes of files.

If a mode change is required it needs to be explained in the commit
message.

Regards

Marcel



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-08-23 11:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-23 10:45 [PATCH 1/2] add cdma radio setting caiwen.zhang
2010-08-23 11:22 ` Marcel Holtmann
  -- strict thread matches above, loose matches on Subject: below --
2010-08-23  6:36 caiwenzhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox