From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH] Fix common misspellings
Date: Tue, 14 Sep 2010 10:35:54 +0900 [thread overview]
Message-ID: <1284428154.2405.29.camel@localhost.localdomain> (raw)
In-Reply-To: <1284427973-22306-1-git-send-email-lucas.demarchi@profusion.mobi>
[-- Attachment #1: Type: text/plain, Size: 1698 bytes --]
Hi Lucas,
> Apply to all files the list of common misspellings found at
> http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines.
>
> From the list cited above, the substitution found the following
> misspellings:
>
> accomodate->accommodate
> fomr->from
> priviledge->privilege
> proprietory->proprietary
> reponsible->responsible
> seperately->separately
> subsidary(-ies)->subsidiary(-ies)
> succeded->succeeded
> targetted->targeted
> transfering->transferring
> witheld->withheld
> withold->withhold
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
no signed-off-by please. We don't use it.
> ---
> TODO | 4 ++--
> doc/call-settings-api.txt | 6 +++---
> doc/ofono-paper.txt | 4 ++--
> doc/voicecallmanager-api.txt | 2 +-
> drivers/atmodem/voicecall.c | 2 +-
> drivers/hfpmodem/voicecall.c | 2 +-
> drivers/isimodem/gpds.h | 2 +-
> drivers/isimodem/gprs-context.c | 2 +-
> drivers/isimodem/gprs.c | 2 +-
> drivers/stemodem/voicecall.c | 2 +-
> gatchat/gatppp.c | 2 +-
> gatchat/gsmdial.c | 2 +-
> gatchat/test-server.c | 2 +-
> gisi/client.c | 2 +-
> gisi/server.c | 2 +-
> src/util.c | 2 +-
> 16 files changed, 20 insertions(+), 20 deletions(-)
While in general I am all for fixing spelling mistakes, but you need to
break this down into logical chunks. Just doing a mega patch that does
changes all over the place is not working out.
Regards
Marcel
next prev parent reply other threads:[~2010-09-14 1:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 1:32 [PATCH] Fix common misspellings Lucas De Marchi
2010-09-14 1:35 ` Marcel Holtmann [this message]
2010-09-14 2:32 ` Lucas De Marchi
2010-09-14 2:37 ` Denis Kenzior
2010-09-14 3:06 ` [PATCH 1/6] Fix common misspellings in documentation Lucas De Marchi
2010-09-14 3:06 ` [PATCH 2/6] Fix common misspellings in drivers Lucas De Marchi
2010-09-14 5:08 ` Marcel Holtmann
2010-09-14 6:51 ` Aki Niemi
2010-09-14 7:02 ` Marcel Holtmann
2010-09-14 3:06 ` [PATCH 3/6] Fix common misspellings in gatchat Lucas De Marchi
2010-09-14 3:06 ` [PATCH 4/6] Fix common misspelling in gisi Lucas De Marchi
2010-09-14 3:06 ` [PATCH 5/6] Fix common misspellings in TODO file Lucas De Marchi
2010-09-14 3:06 ` [PATCH 6/6] Fix common misspelling in source files Lucas De Marchi
2010-09-14 3:21 ` [PATCH] Fix common misspellings Gu, Yang
2010-09-14 22:36 ` Lucas De Marchi
2010-09-15 5:26 ` Gu, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284428154.2405.29.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox