From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Fix common misspellings
Date: Mon, 13 Sep 2010 21:37:45 -0500 [thread overview]
Message-ID: <4C8EDFF9.4060006@gmail.com> (raw)
In-Reply-To: <AANLkTin7tZ+zWXdZaOcRa5vDtFq=6d_WJRokjaGU2CMu@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
Hi Lucas,
On 09/13/2010 09:32 PM, Lucas De Marchi wrote:
> On Mon, Sep 13, 2010 at 10:35 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
>> no signed-off-by please. We don't use it.
>
> Sorry, I forgot this project follows the same rules as for connman.
>
>> While in general I am all for fixing spelling mistakes, but you need to
>> break this down into logical chunks. Just doing a mega patch that does
>> changes all over the place is not working out.
>
> How do you want me to split this patch? In my opinion it's not that
> big and it's almost only 1 change per file. If the split is required,
> I think the options are 1) per changed word or 2) per file or 3)
> changes in documentation + changes in source files.
>
Can you split them 1 / directory? E.g.
- patch for files in gatchat/
- patch for files in doc/
- patch for files in drivers/
- patch for files in gisi
etc
Regards,
-Denis
next prev parent reply other threads:[~2010-09-14 2:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 1:32 [PATCH] Fix common misspellings Lucas De Marchi
2010-09-14 1:35 ` Marcel Holtmann
2010-09-14 2:32 ` Lucas De Marchi
2010-09-14 2:37 ` Denis Kenzior [this message]
2010-09-14 3:06 ` [PATCH 1/6] Fix common misspellings in documentation Lucas De Marchi
2010-09-14 3:06 ` [PATCH 2/6] Fix common misspellings in drivers Lucas De Marchi
2010-09-14 5:08 ` Marcel Holtmann
2010-09-14 6:51 ` Aki Niemi
2010-09-14 7:02 ` Marcel Holtmann
2010-09-14 3:06 ` [PATCH 3/6] Fix common misspellings in gatchat Lucas De Marchi
2010-09-14 3:06 ` [PATCH 4/6] Fix common misspelling in gisi Lucas De Marchi
2010-09-14 3:06 ` [PATCH 5/6] Fix common misspellings in TODO file Lucas De Marchi
2010-09-14 3:06 ` [PATCH 6/6] Fix common misspelling in source files Lucas De Marchi
2010-09-14 3:21 ` [PATCH] Fix common misspellings Gu, Yang
2010-09-14 22:36 ` Lucas De Marchi
2010-09-15 5:26 ` Gu, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8EDFF9.4060006@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox