From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 2/6] stemodem: add default case
Date: Tue, 26 Oct 2010 17:35:26 +0200 [thread overview]
Message-ID: <1288107326.3613.22.camel@aeonflux> (raw)
In-Reply-To: <1288107113-2740-3-git-send-email-mika.liljeberg@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
Hi Mika,
> ---
> drivers/stemodem/radio-settings.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/stemodem/radio-settings.c b/drivers/stemodem/radio-settings.c
> index 5b16ec0..a345975 100644
> --- a/drivers/stemodem/radio-settings.c
> +++ b/drivers/stemodem/radio-settings.c
> @@ -90,7 +90,7 @@ static gboolean ofono_mode_to_ste_mode(enum ofono_radio_access_mode mode,
> case OFONO_RADIO_ACCESS_MODE_UMTS:
> *stemode = STE_RADIO_WCDMA_ONLY;
> return TRUE;
> - case OFONO_RADIO_ACCESS_MODE_LTE:
> + default:
> break;
no default for enums please. I want the compiler to warn us about not
handled switch statements.
Regards
Marcel
next prev parent reply other threads:[~2010-10-26 15:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 15:31 [PATCH 0/6] Fast dormancy support Mika Liljeberg
2010-10-26 15:31 ` [PATCH 1/6] radio settings: fix mode initializion Mika Liljeberg
2010-10-28 3:27 ` Denis Kenzior
2010-10-26 15:31 ` [PATCH 2/6] stemodem: add default case Mika Liljeberg
2010-10-26 15:35 ` Marcel Holtmann [this message]
2010-10-26 15:43 ` Mika.Liljeberg
2010-10-26 16:24 ` Marcel Holtmann
2010-10-27 7:06 ` Mika.Liljeberg
2010-10-27 9:12 ` Marcel Holtmann
2010-10-26 15:31 ` [PATCH 3/6] radio settings: add FastDormancy property Mika Liljeberg
2010-10-28 3:27 ` Denis Kenzior
2010-10-28 13:32 ` Mika.Liljeberg
2010-10-28 15:19 ` Denis Kenzior
2010-10-29 8:52 ` Mika.Liljeberg
2010-10-29 14:34 ` Denis Kenzior
2010-11-01 9:18 ` Mika.Liljeberg
2010-10-26 15:31 ` [PATCH 4/6] test: add script to control fast dormancy Mika Liljeberg
2010-10-28 3:27 ` Denis Kenzior
2010-10-26 15:31 ` [PATCH 5/6] isimodem: add support for FastDormancy property Mika Liljeberg
2010-10-28 3:28 ` Denis Kenzior
2010-10-26 15:31 ` [PATCH 6/6] TODO: mark fast dormancy as done Mika Liljeberg
2010-10-28 3:28 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288107326.3613.22.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox