Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 5/5] Makefile: add call counters to the build
Date: Mon, 15 Nov 2010 17:13:55 +0100	[thread overview]
Message-ID: <1289837635.3266.126.camel@aeonflux> (raw)
In-Reply-To: <c00e972ede1dd58920d80c763b05a5d871637358.1289819191.git.Andras.Domokos@nokia.com>

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

Hi Andras,

>  Makefile.am |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index f841b4c..a1c6097 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -295,6 +295,9 @@ builtin_modules += example_nettime
>  builtin_sources += examples/nettime.c
>  endif
>  
> +builtin_modules += cc
> +builtin_sources += src/callcounters.c
> +

what is this? Plugins do not belong under src/. That is reserved for
oFono core functionality only.

Regards

Marcel



  reply	other threads:[~2010-11-15 16:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15 11:50 [PATCH 0/5] Call Counters Andras Domokos
2010-11-15 11:50 ` [RFC PATCH 1/5] history: expand history API include file Andras Domokos
2010-11-22 15:32   ` Denis Kenzior
2010-11-15 11:50 ` [RFC PATCH 2/5] history: expand history API Andras Domokos
2010-11-15 11:50 ` [RFC PATCH 3/5] voicecall: take into use the new history function Andras Domokos
2010-11-15 11:50 ` [RFC PATCH 4/5] voicecall: add call counters Andras Domokos
2010-11-22 15:34   ` Denis Kenzior
2010-11-15 11:50 ` [RFC PATCH 5/5] Makefile: add call counters to the build Andras Domokos
2010-11-15 16:13   ` Marcel Holtmann [this message]
2010-11-15 16:13 ` [PATCH 0/5] Call Counters Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289837635.3266.126.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox