From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 4/5] voicecall: add call counters
Date: Mon, 22 Nov 2010 09:34:47 -0600 [thread overview]
Message-ID: <4CEA8D97.4060202@gmail.com> (raw)
In-Reply-To: <68a1a9e9cf371358b6c100b372ae93a50e095bd7.1289819191.git.Andras.Domokos@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
Hi Andras,
On 11/15/2010 05:50 AM, Andras Domokos wrote:
> ---
> src/callcounters.c | 388 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 388 insertions(+), 0 deletions(-)
> create mode 100644 src/callcounters.c
>
> diff --git a/src/callcounters.c b/src/callcounters.c
This patch should go together with Patch 5. It is also missing the API
documentation (which could be in a separate patch if you prefer).
This file should also be inside the plugins directory and not src.
Regards,
-Denis
next prev parent reply other threads:[~2010-11-22 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 11:50 [PATCH 0/5] Call Counters Andras Domokos
2010-11-15 11:50 ` [RFC PATCH 1/5] history: expand history API include file Andras Domokos
2010-11-22 15:32 ` Denis Kenzior
2010-11-15 11:50 ` [RFC PATCH 2/5] history: expand history API Andras Domokos
2010-11-15 11:50 ` [RFC PATCH 3/5] voicecall: take into use the new history function Andras Domokos
2010-11-15 11:50 ` [RFC PATCH 4/5] voicecall: add call counters Andras Domokos
2010-11-22 15:34 ` Denis Kenzior [this message]
2010-11-15 11:50 ` [RFC PATCH 5/5] Makefile: add call counters to the build Andras Domokos
2010-11-15 16:13 ` Marcel Holtmann
2010-11-15 16:13 ` [PATCH 0/5] Call Counters Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEA8D97.4060202@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox