From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner
Date: Tue, 21 Dec 2010 11:22:39 -0800 [thread overview]
Message-ID: <1292959359.2658.63.camel@aeonflux> (raw)
In-Reply-To: <4D10FD6D.20804@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]
Hi Denis,
> >>> We could document this as Freerunner specific notes to point people into
> >>> the right direction. And we should maybe to the same for IFX since that
> >>> is currently only documented in the GIT commit logs.
> >>
> >> Documentation inside the individual modem driver is the way to go. And
> >> IFX isn't even documented in git commit logs. I looked ;)
> >
> > commit 3443a7a177fbaca24c84658968aff0a55db8a51d
> > Author: Marcel Holtmann <marcel@holtmann.org>
> > Date: Sat Sep 18 22:08:41 2010 +0900
> >
> > udev: Add support for IFX device detection
> >
> > The IFX device detection is pretty static, but instead of using
> > a static configuration file it is important to know when the device
> > node is actually present. For this udev is perfect. Adding a simple
> > udev rule is all that it takes:
> >
> > KERNEL=="ttyIFX[0-9]*", ENV{OFONO_DRIVER}="ifx"
> >
> > With this rule for every TTY with the kernel name like ttyIFX0, a new
> > modem will be added and the IFX modem plugin driver requested for it.
> >
> > this is not enough?
>
> Then I didn't look far back enough (or I'm simply blind). But I still
> prefer this to be inside the driver or HACKING.calypso for easier access.
I am with you that this needs to be documented better than GIT commit
logs.
However I do prefer doc/calypso-modem.txt and doc/ifx-modem.txt though
since I don't wanna clutter the root directory.
Regards
Marcel
next prev parent reply other threads:[~2010-12-21 19:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 22:12 PATCH: Enable udev-based autodetection of calypso modem on Freerunner Neil Jerram
2010-12-20 23:39 ` Denis Kenzior
2010-12-21 12:01 ` Neil Jerram
2010-12-21 18:01 ` Denis Kenzior
2010-12-21 18:13 ` Marcel Holtmann
2010-12-21 18:16 ` Denis Kenzior
2010-12-21 19:05 ` Marcel Holtmann
2010-12-21 19:18 ` Denis Kenzior
2010-12-21 19:22 ` Marcel Holtmann [this message]
2010-12-21 19:33 ` Denis Kenzior
2010-12-21 21:34 ` Neil Jerram
2010-12-22 13:37 ` Marcel Holtmann
2010-12-23 12:02 ` Neil Jerram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292959359.2658.63.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox