Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]

Hi Neil,

On 12/15/2010 04:12 PM, Neil Jerram wrote:
> Hi all,
> 
> With the patch below, ofono-0.36 (the current Debian unstable version)
> detects the calypso modem on my freerunner.  (Whereas without it, it
> doesn't.)

We prefer if you use git send-email to format the patch for submission.
 For now I applied your patch without the ofono.rules changes.

> 
> I don't feel confident that the ofono.rules change is in its nicest
> possible form, and (IIUC) it's dependent on these earlier rules in
> /lib/udev/rules.d/55-openmoko-gta01-gta02.rules on my phone:
> 
> # Samsung UARTS
> KERNEL=="s3c2410_serial[0-9]",   NAME="ttySAC%n"
> KERNEL=="ttySAC[0-9]",   NAME="ttySAC%n"
> 
> Given that the actual udev DB entry, under 2.6.34, is:
> 
> P: /devices/platform/s3c2440-uart.0/tty/ttySAC0
> N: ttySAC0
> S: char/204:64
> E: UDEV_LOG=3
> E: DEVPATH=/devices/platform/s3c2440-uart.0/tty/ttySAC0
> E: MAJOR=204
> E: MINOR=64
> E: DEVNAME=/dev/ttySAC0
> E: SUBSYSTEM=tty
> E: DEVLINKS=/dev/char/204:64
> 

I think the better way would be to drop a udev rule directly into
/etc/udev.d or similar.  The rule should be as simple as:
KERNEL=="ttySAC0", ENV{OFONO_DRIVER}="calypso"

Let me know if this works for you and I can add a comment in the calypso
plugin.

Reg