Re: [RFC PATCHv2 1/4] Automatic provisioning of GPRS context settings

[Jukka Saunamaki <jukka.saunamaki@nokia.com>]

[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]

Hello Marcel,

> the oFono plugins work like kernel modules. They are pretty much
> generic. Inside the init function you can a driver register function and
> inside the exit function, you call the driver unregister function.

Right, that seems clear enough.

> static int setup_context(struct ofono_gprs_primary_context *context)
> {
> 	...
> 
> 	return 0;
> }
> 
> static const ofono_gprs_provision_driver driver {
> 	.name =	"test",
> 	.setup_context = setup_context,
> };

I guess that current struct ofono_gprs_primary_context* is not enough
for provisioning data, it is missing at least name, MMS proxy and server
information. Should those (and whatever might be needed in future) be
added into that struct, or should we define some 
struct ofono_gprs_provisioning_data {
	struct ofono_gprs_primary_context pri;
	char name[MAX_CONTEXT_NAME_LENGTH + 1];
	char message_proxy[MAX_MESSAGE_PROXY_LENGTH + 1];
	char message_center[MAX_MESSAGE_CENTER_LENGTH + 1];	
}
struct pri_context in gprs.c contains everything, but has extra
gprs-internal stuff.  

Also setup_context() needs ofono_gprs_context_type as in-parameter.


And a question about the priorities, if there is more than one
provisioning plugin: would plugins be called in priority order, and
after first returns something, rest would not be called?

--Jukka