Re: [RFC PATCHv2 1/4] Automatic provisioning of GPRS context settings

[Kalle Valo <kalle.valo@canonical.com>]

[-- Attachment #1: Type: text/plain, Size: 1747 bytes --]

Jukka Saunamaki <jukka.saunamaki@nokia.com> writes:

> Hello

Moro,

> On Mon, 2011-01-03 at 10:57 +0200, Kalle Valo wrote:
>> Jukka Saunamaki <jukka.saunamaki@nokia.com> writes:
>>
>> > <access type="mms" mcc="246" mnc="81" spn="oFono" name="Phonesim MMS-GPRS" apn="mms.apn" protocol="ipv4" username="mmsuser" password="mmspass" proxy="10.11.12.13:8080" mmsserver="http://mms.example.com:8000"/>
>> > </settings>
>> 
>> The format here doesn't look very extensible to me, more like csv with
>> steroids and not proper xml. Any particular reason why you can't use the
>> same format as in mobile-broadband-provider-info?
>> 
>> http://git.gnome.org/browse/mobile-broadband-provider-info/tree/serviceproviders.xml
>
> Well, my intention was to make format simple and fast to parse, but
> still be extensible enough, which I think my proposed format fulfills. 
>
> These <access>-elements contain just data needed for GPRS context
> settings (as attributes), and if there is need for any other operator
> specific provisioning information, you can always add separate elements,
> this is still proper XML.

But IMHO it is really ugly and not a properly designed XML. You could do
the same even with this style of CSV and have the same extensibility:

type="internet",mcc="246",mnc="81",spn="oFono",\
name="Phonesim Internet-GPRS",pn="internet.apn"

If you want to use XML, why not do it properly? XML parsing can't be
that performance critical. And if it is (to my great surprise), then XML
is not the correct choise for this.

Again, why not use mobile-broadband-provider-info DTD? If there's something
missing, I'm sure maintainers are willing to extend it. No need to
reinvent the wheel.

-- 
Kalle Valo