Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [RFC PATCH] gprs: add function to handle activated context
Date: Thu, 06 Jan 2011 09:39:21 -0800	[thread overview]
Message-ID: <1294335561.2501.4.camel@aeonflux> (raw)
In-Reply-To: <AANLkTimxkKAjcEdS9hGLECWEaW4o+ygPU3RCikFpcK0i@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

Hi Sjur,

> > +static void gprs_cid_take(struct ofono_gprs *gprs, unsigned int id)
> > +{
> > +       idmap_take(gprs->cid_map, id);
> > +}
> > +
> How do we assure that this CID is not already in use?
> I think the M7400 is going to use CID=0 and M700 uses CID=1.
> Perhaps we should make sure CID=0 is a legal value and reserve CID 0
> and 1 at start up.

I thought that we came to the conclusion that CID=0 is pretty much a
really bad idea. So I would prefer that your modem is actually not using
CID=0 ever.

Regards

Marcel



  parent reply	other threads:[~2011-01-06 17:39 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-05 17:25 [RFC PATCH] gprs: add function to handle activated context Soum, RedouaneX
2011-01-06  0:12 ` Marcel Holtmann
2011-01-06  0:17   ` Denis Kenzior
2011-01-07  8:52     ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-07 15:45       ` Joly, Frederic
2011-01-07 21:07       ` Denis Kenzior
2011-01-06 13:28   ` Soum, RedouaneX
2011-01-07  8:50   ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-07 10:38     ` Aki Niemi
2011-01-06 12:02 ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-06 14:59   ` Soum, RedouaneX
2011-01-06 16:47     ` Denis Kenzior
2011-01-06 17:14     ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-06 16:37   ` Denis Kenzior
2011-01-06 17:39   ` Marcel Holtmann [this message]
2011-01-06 17:45     ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-06 17:53       ` Marcel Holtmann
2011-01-06 18:10       ` Denis Kenzior
2011-01-07 15:14         ` Joly, Frederic
2011-01-07 15:38           ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-07 17:52             ` Joly, Frederic
2011-01-07 21:01               ` Denis Kenzior
2011-01-11 12:46                 ` Soum, RedouaneX
2011-01-17 14:21                 ` Pekka Pessi
2011-01-17 18:39                   ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-17 18:51                     ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-17 22:39                     ` Pekka Pessi
2011-01-17 23:15                       ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294335561.2501.4.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox