From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 3/3] Support for pkg-config
Date: Tue, 25 Jan 2011 00:20:33 +0100 [thread overview]
Message-ID: <1295911233.1520.8.camel@aeonflux> (raw)
In-Reply-To: <1295873450-5891-2-git-send-email-remi.denis-courmont@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 1861 bytes --]
Hi Remi,
> .gitignore | 1 +
> Makefile.am | 10 ++++++++--
> ofono.pc.in | 10 ++++++++++
> 3 files changed, 19 insertions(+), 2 deletions(-)
> create mode 100644 ofono.pc.in
>
> diff --git a/.gitignore b/.gitignore
> index 7cfb1d9..59308be 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -20,6 +20,7 @@ install-sh
> libtool
> ltmain.sh
> missing
> +ofono.pc
> stamp-h1
> autom4te.cache
>
> diff --git a/Makefile.am b/Makefile.am
> index 1f09c11..e8570f8 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -21,6 +21,9 @@ local_headers = $(foreach file,$(pkginclude_HEADERS) \
> $(nodist_pkginclude_HEADERS), \
> include/ofono/$(notdir $(file)))
>
> +pkgconfigdir = $(libdir)/pkgconfig
> +pkgconfig_DATA = ofono.pc
> +
>
> if DATAFILES
> dbusconfdir = @DBUS_CONFDIR@
> @@ -364,7 +367,7 @@ src_ofonod_LDFLAGS = -Wl,--export-dynamic \
>
> BUILT_SOURCES = $(local_headers)
>
> -CLEANFILES = src/builtin.h $(BUILT_SOURCES) $(rules_DATA)
> +CLEANFILES = src/builtin.h ofono.pc $(BUILT_SOURCES) $(rules_DATA)
>
> plugindir = $(pkglibdir)/plugins
>
> @@ -477,7 +480,7 @@ testdir = $(pkglibdir)/test
> test_SCRIPTS = $(test_scripts)
> endif
>
> -EXTRA_DIST = src/genbuiltin $(udev_files) \
> +EXTRA_DIST = src/genbuiltin ofono.pc.in $(udev_files) \
> $(doc_files) $(test_scripts)
>
> dist_man_MANS = doc/ofonod.8
> @@ -572,5 +575,8 @@ include/ofono/%.h: include/%.h
> $(AM_V_at)$(MKDIR_P) include/ofono
> $(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
>
> +%.pc: %.pc.in $(builddir)/config.status
> + $(AM_V_GEN)$(SHELL) ./config.status --file=$@ >/dev/null
> +
I do wanna keep this in sync with ConnMan actually. In ConnMan we create
this one via configure.ac script. So I think we should do the same here
as well.
Regards
Marcel
next prev parent reply other threads:[~2011-01-24 23:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 12:50 [PATCH 2/3] Use dist_ prefix as applicable =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-24 12:50 ` [PATCH 3/3] Support for pkg-config =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-24 23:20 ` Marcel Holtmann [this message]
2011-01-24 23:17 ` [PATCH 2/3] Use dist_ prefix as applicable Marcel Holtmann
2011-01-26 10:23 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295911233.1520.8.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox