From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 2/3] Use dist_ prefix as applicable
Date: Wed, 26 Jan 2011 11:23:05 +0100 [thread overview]
Message-ID: <1296037385.1520.106.camel@aeonflux> (raw)
In-Reply-To: <1295873450-5891-1-git-send-email-remi.denis-courmont@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]
Hi Remi,
> Makefile.am | 12 +++++-------
> 1 files changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index f941a19..1f09c11 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -25,17 +25,17 @@ local_headers = $(foreach file,$(pkginclude_HEADERS) \
> if DATAFILES
> dbusconfdir = @DBUS_CONFDIR@
>
> -dbusconf_DATA = src/ofono.conf
> +dist_dbusconf_DATA = src/ofono.conf
so I ran all dist tests on my systems and run the whole build check
process that I am normally running. I can not find any problem with it.
Maybe previously I was using a broken automake version or something like
that. So I am fine with this patch ...
> if SYSTEMD
> systemdunitdir = @SYSTEMD_UNITDIR@
>
> -systemdunit_DATA = src/ofono.service
> +dist_systemdunit_DATA = src/ofono.service
> endif
... however this part is wrong. It is an ofono.service.in file. So
please leave this part out.
> -EXTRA_DIST = src/genbuiltin $(conf_files) $(udev_files) \
> +EXTRA_DIST = src/genbuiltin $(udev_files) \
> $(doc_files) $(test_scripts)
And these fit into one line now. So just put everything in one line.
Regards
Marcel
prev parent reply other threads:[~2011-01-26 10:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 12:50 [PATCH 2/3] Use dist_ prefix as applicable =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-24 12:50 ` [PATCH 3/3] Support for pkg-config =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-24 23:20 ` Marcel Holtmann
2011-01-24 23:17 ` [PATCH 2/3] Use dist_ prefix as applicable Marcel Holtmann
2011-01-26 10:23 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296037385.1520.106.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox