Re: [PATCH] Don't use c++ keyword in public header files

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

Hi Lucas,

>  include/sim.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/sim.h b/include/sim.h
> index 81df60e..6e93769 100644
> --- a/include/sim.h
> +++ b/include/sim.h
> @@ -154,7 +154,7 @@ struct ofono_sim_driver {
>  			ofono_sim_lock_unlock_cb_t cb, void *data);
>  	void (*change_passwd)(struct ofono_sim *sim,
>  			enum ofono_sim_password_type type,
> -			const char *old, const char *new,
> +			const char *p_old, const char *p_new,
>  			ofono_sim_lock_unlock_cb_t cb, void *data);
>  	void (*lock)(struct ofono_sim *sim, enum ofono_sim_password_type type,
>  			int enable, const char *passwd,

why is this exactly a problem?

And if you really wanna do that, then please not something cryptic like
p_new. Names like new_passwd or new_pw are way more descriptive.

Another possibility is using the combination current + passwd.

Regards

Marcel