Re: [PATCH] Don't use c++ keyword in public header files

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

Hi Lucas,

> >> >> -                     const char *old, const char *new,
> >> >> +                     const char *p_old, const char *p_new,
> >> >>                       ofono_sim_lock_unlock_cb_t cb, void *data);
> >> >>       void (*lock)(struct ofono_sim *sim, enum ofono_sim_password_type type,
> >> >>                       int enable, const char *passwd,
> >> >
> >> > why is this exactly a problem?
> >>
> >> I did it only because the file contains this:
> >>
> >> #ifdef __cplusplus
> >> extern "C" {
> >> #endif
> >>
> >>
> >> So I thought someone might want to write a plugin in C++ or something
> >> that includes sim.h
> >
> > and at that point you told the compiler that it is C code and not C++
> > and it should be just fine.
> 
> This only works for the link phase, because of the name mangling in C++.
> 
> > I think it will compile just fine. Try to test it ;)
> 
> It doesn't. Example:

fair enough. Send a patch that uses one of the other proposed names. And
you might wanna update the atmodem and isimodem driver as well to just
be consistent.

Regards

Marcel