From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH] Enable hs 2330 MBM modem
Date: Fri, 28 Jan 2011 10:16:47 +0100 [thread overview]
Message-ID: <1296206207.1520.165.camel@aeonflux> (raw)
In-Reply-To: <1296191123-4529-1-git-send-email-zhigang.li@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1867 bytes --]
Hi Zhigang,
> diff --git a/plugins/udev.c b/plugins/udev.c
> index 202b225..810049a 100644
> --- a/plugins/udev.c
> +++ b/plugins/udev.c
> @@ -123,6 +123,7 @@ static void add_mbm(struct ofono_modem *modem,
> g_str_has_suffix(desc, "Minicard Modem 2") ||
> g_str_has_suffix(desc, "Mini-Card Modem") ||
> g_str_has_suffix(desc, "Broadband Modem") ||
> + g_str_has_suffix(desc, "Module Modem") ||
> g_str_has_suffix(desc, "Broadband USB Modem")) {
> devnode = udev_device_get_devnode(udev_device);
> if (ofono_modem_get_string(modem, MODEM_DEVICE) == NULL)
> @@ -131,16 +132,19 @@ static void add_mbm(struct ofono_modem *modem,
> ofono_modem_set_string(modem, DATA_DEVICE, devnode);
> } else if (g_str_has_suffix(desc, "Minicard Data Modem") ||
> g_str_has_suffix(desc, "Mini-Card Data Modem") ||
> + g_str_has_suffix(desc, "Data Modem") ||
I think this should be "Module Data Modem".
> g_str_has_suffix(desc, "Broadband Data Modem")) {
> devnode = udev_device_get_devnode(udev_device);
> ofono_modem_set_string(modem, DATA_DEVICE, devnode);
> } else if (g_str_has_suffix(desc, "Minicard GPS Port") ||
> g_str_has_suffix(desc, "Mini-Card GPRS Port") ||
> + g_str_has_suffix(desc, "Module NMEA") ||
> g_str_has_suffix(desc, "Broadband GPS Port")) {
> devnode = udev_device_get_devnode(udev_device);
> ofono_modem_set_string(modem, GPS_DEVICE, devnode);
> } else if (g_str_has_suffix(desc, "Minicard Network Adapter") ||
> g_str_has_suffix(desc, "Mini-Card Network Adapter") ||
> + g_str_has_suffix(desc, "Module Network Adapter") ||
> g_str_has_suffix(desc, "Broadband Network Adapter") ||
> g_str_has_suffix(desc, "Minicard NetworkAdapter")) {
> devnode = get_property(udev_device, "INTERFACE");
Rest seems fine to me.
Regards
Marcel
next prev parent reply other threads:[~2011-01-28 9:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 5:05 [PATCH] Enable hs 2330 MBM modem Zhigang Li
2011-01-28 9:16 ` Marcel Holtmann [this message]
2011-02-14 2:45 ` Li, Zhigang
2011-02-17 3:16 ` Marcel Holtmann
2011-02-17 6:57 ` Li, Zhigang
2011-02-23 8:50 ` Li, Zhigang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296206207.1520.165.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox