Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: RE: [PATCH] Enable hs 2330 MBM modem
Date: Wed, 16 Feb 2011 19:16:46 -0800	[thread overview]
Message-ID: <1297912606.2519.22.camel@aeonflux> (raw)
In-Reply-To: <B32E3D5F1713054290B4FF257B89C51A29DEF646DF@shsmsx502.ccr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hi Zhigan,

> > >+			g_str_has_suffix(desc, "Data Modem") ||
> 
> > I think this should be "Module Data Modem".
> 
> This is confusing part, with my test with this modem on MeeGo image, the Module Data Modem doesn't work and only Data Modem works.
> 
> So I think it should be ok.

looks wrong to me. Please get the lsusb -v out for this modem where it
lists the interface strings.

Regards

Marcel



  reply	other threads:[~2011-02-17  3:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-28  5:05 [PATCH] Enable hs 2330 MBM modem Zhigang Li
2011-01-28  9:16 ` Marcel Holtmann
2011-02-14  2:45   ` Li, Zhigang
2011-02-17  3:16     ` Marcel Holtmann [this message]
2011-02-17  6:57       ` Li, Zhigang
2011-02-23  8:50         ` Li, Zhigang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297912606.2519.22.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox