* [PATCH 0/1] Fix issue in ifxmodem set rat mode @ 2011-02-11 19:20 Jeevaka Badrappan 2011-02-11 19:20 ` [PATCH 1/1] ifxmodem: fix issue in " Jeevaka Badrappan 0 siblings, 1 reply; 3+ messages in thread From: Jeevaka Badrappan @ 2011-02-11 19:20 UTC (permalink / raw) To: ofono [-- Attachment #1: Type: text/plain, Size: 492 bytes --] Hi, Find the syntax of the XRAT set command: Defined values <AcT> indicates the radio access technology and may be 0 GSM single mode 1 GSM / UMTS Dual mode 2 UTRAN (UMTS) < PreferredAct > This parameter is used for network registration in case of <AcT>=1. 0 RAT GSM 2 RAT UMTS Regards, Jeevaka Jeevaka Badrappan (1): ifxmodem: fix issue in set rat mode drivers/ifxmodem/radio-settings.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] ifxmodem: fix issue in set rat mode 2011-02-11 19:20 [PATCH 0/1] Fix issue in ifxmodem set rat mode Jeevaka Badrappan @ 2011-02-11 19:20 ` Jeevaka Badrappan 2011-02-11 19:44 ` Marcel Holtmann 0 siblings, 1 reply; 3+ messages in thread From: Jeevaka Badrappan @ 2011-02-11 19:20 UTC (permalink / raw) To: ofono [-- Attachment #1: Type: text/plain, Size: 736 bytes --] --- drivers/ifxmodem/radio-settings.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/ifxmodem/radio-settings.c b/drivers/ifxmodem/radio-settings.c index fd590ae..bd292c5 100644 --- a/drivers/ifxmodem/radio-settings.c +++ b/drivers/ifxmodem/radio-settings.c @@ -145,7 +145,10 @@ static void ifx_set_rat_mode(struct ofono_radio_settings *rs, goto error; } - snprintf(buf, sizeof(buf), "AT+XRAT=%u,%u", value, preferred); + if (value == 1) + snprintf(buf, sizeof(buf), "AT+XRAT=%u,%u", value, preferred); + else + snprintf(buf, sizeof(buf), "AT+XRAT=%u", value); if (g_at_chat_send(rsd->chat, buf, none_prefix, xrat_modify_cb, cbd, g_free) > 0) -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ifxmodem: fix issue in set rat mode 2011-02-11 19:20 ` [PATCH 1/1] ifxmodem: fix issue in " Jeevaka Badrappan @ 2011-02-11 19:44 ` Marcel Holtmann 0 siblings, 0 replies; 3+ messages in thread From: Marcel Holtmann @ 2011-02-11 19:44 UTC (permalink / raw) To: ofono [-- Attachment #1: Type: text/plain, Size: 179 bytes --] Hi Jeevaka, > drivers/ifxmodem/radio-settings.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) patch has been applied. Thanks. Regards Marcel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-11 19:44 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-02-11 19:20 [PATCH 0/1] Fix issue in ifxmodem set rat mode Jeevaka Badrappan 2011-02-11 19:20 ` [PATCH 1/1] ifxmodem: fix issue in " Jeevaka Badrappan 2011-02-11 19:44 ` Marcel Holtmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox