Re: [PATCH v4 2/3] Add SIM900 detection support.

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

Hi Renat,

> This allows for detection of SIM900 modem module in case of
> appropriate driver specified in udev rules.
> 
> Example rule:
> KERNEL=="gsmtty3", ENV{OFONO_DRIVER}="sim900"

you could also use the 27.010 support that is included in oFono itself
and set it up from within the plugin. I assume you have a reason for
using N_GSM.

> 
> ---
>  plugins/udev.c |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
> 
> diff --git a/plugins/udev.c b/plugins/udev.c
> index d0673f7..f05af48 100644
> --- a/plugins/udev.c
> +++ b/plugins/udev.c
> @@ -193,6 +193,19 @@ static void add_nokiacdma(struct ofono_modem *modem,
>  	ofono_modem_register(modem);
>  }
>  
> +static void add_sim900(struct ofono_modem *modem,
> +                       struct udev_device *udev_device)
> +{
> +        const char *devnode;
> +
> +        DBG("modem %p", modem);
> +
> +        devnode = udev_device_get_devnode(udev_device);
> +        ofono_modem_set_string(modem, "Device", devnode);
> +
> +        ofono_modem_register(modem);
> +}
> +
>  static void add_modem(struct udev_device *udev_device)
>  {
>  	struct ofono_modem *modem;
> @@ -271,6 +284,8 @@ done:
>  		add_tc65(modem, udev_device);
>  	else if (g_strcmp0(driver, "nokiacdma") == 0)
>  		add_nokiacdma(modem, udev_device);
> +        else if (g_strcmp0(driver, "sim900") == 0)
> +                add_sim900(modem, udev_device);
>  }

Something went wrong here. Spaces?

Regards

Marcel