Re: [PATCH v4 1/3] SIMCOM SIM900 module support

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]

Hi Renat,

> >>>>> +  /* For obtain correct sms service number */
> >>>>> +  g_at_chat_send(data->modem, "AT+CSCS=\"GSM\"", NULL,
> >>>>> +                  NULL, NULL, NULL);
> >>>>
> >>>> you might better introduce a OFONO_VENDOR_SIM900 quirk and use that in
> >>>> the SMS atom driver. The phonebook support will also end up overwriting
> >>>> this one later on. So I am not even sure this works reliable this way.
> >>>> Might be just pure luck with the order of the atom.
> >>>>
> >>>
> >>> Actually this is fine assuming the modem does not support UTF-8
> >>> character set.  The builtin assumption for most atoms is that CSCS is
> >>> set to something sane before they're initialized.  The phonebook driver
> >>> will temporarily switch to UCS2 for the duration of the phonebook read
> >>> and restore the previous setting.
> >>
> >> we did a vendor quirk for this for USSD of Qualcomm based modems. Maybe
> >> we should then also move that into the modem plugins.
> >>
> >
> > Yes, I think that would be cleaner.  I'll take care of it.
> >

> How I understand, it is correct that I call CSCS command from
> sim900_enable? Or I must move it in another stage?

Denis and I pushed some patches to call AT+CSCS in the plugins. I think
the only thing you need to consider is doing after you are sure a SIM
card is present.

> Can I add OFONO_VENDOR_SIM900 in drivers/atmodem/vendor.h for use it
> instead OFONO_VENDOR_NOKIA in ofono_netreg_create?

Yes. Just send a separate patch adding the vendor quirk.

Regards

Marcel