From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 2/3] changing depreciated libtool initialization to modern one
Date: Fri, 23 Mar 2012 12:09:49 -0700 [thread overview]
Message-ID: <1332529789.1870.58.camel@aeonflux> (raw)
In-Reply-To: <4F4CFDAE.1090604@vfnet.de>
[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]
Hi Jens,
> > Makefile.am | 4 ++++
> > configure.ac | 10 ++++++++--
> > 2 files changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile.am b/Makefile.am
> > index c3a4486..bebcb90 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -1,6 +1,10 @@
> >
> > AM_MAKEFLAGS = --no-print-directory
> >
> > +LIBTOOL_DEPS = @LIBTOOL_DEPS@
> > +libtool: $(LIBTOOL_DEPS)
> > + $(SHELL) ./config.status libtool
> > +
> > gdbus_sources = gdbus/gdbus.h gdbus/mainloop.c gdbus/watch.c \
> > gdbus/object.c gdbus/polkit.c
> >
> > diff --git a/configure.ac b/configure.ac
> > index 34cc526..d82569b 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -31,8 +31,8 @@ AC_PROG_INSTALL
> > m4_define([_LT_AC_TAGCONFIG], [])
> > m4_ifdef([AC_LIBTOOL_TAGS], [AC_LIBTOOL_TAGS([])])
> >
> > -AC_DISABLE_STATIC
> > -AC_PROG_LIBTOOL
> > +dnl AC_DISABLE_STATIC
> > +dnl AC_PROG_LIBTOOL
> >
> > AC_ARG_ENABLE(optimization, AC_HELP_STRING([--disable-optimization],
> > [disable code optimization through compiler]), [
> > @@ -58,6 +58,12 @@ AC_ARG_ENABLE(pie, AC_HELP_STRING([--enable-pie],
> > fi
> > ])
> >
> > +dnl LT_INIT should be invoked after all compiler flags checks, because
> > +dnl of LT_INIT remembers the RPATH stored in test targets which might
> > +dnl be different for different compiler flags (known issue on AIX)
> > +LT_INIT([dlopen,disable-static])
> This should be
> +LT_INIT([dlopen disable-static])
please send an updated patch.
Regards
Marcel
next prev parent reply other threads:[~2012-03-23 19:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 8:17 [PATCH 1/3] add some length verification to avoid reading not owned memory jr_extern
2012-02-28 8:17 ` [PATCH 2/3] changing depreciated libtool initialization to modern one jr_extern
2012-02-28 16:15 ` Jens Rehsack
2012-03-23 19:09 ` Marcel Holtmann [this message]
2012-02-28 8:17 ` [PATCH 3/3] let configure find required libs jr_extern
2012-03-23 19:11 ` Marcel Holtmann
2012-03-23 19:09 ` [PATCH 1/3] add some length verification to avoid reading not owned memory Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332529789.1870.58.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox