From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 3/3] let configure find required libs
Date: Fri, 23 Mar 2012 12:11:53 -0700 [thread overview]
Message-ID: <1332529913.1870.60.camel@aeonflux> (raw)
In-Reply-To: <1330417045-26518-3-git-send-email-jr_extern@vfnet.de>
[-- Attachment #1: Type: text/plain, Size: 2362 bytes --]
Hi Jens,
> Makefile.am | 2 +-
> configure.ac | 24 +++++++++++++++++-------
> 2 files changed, 18 insertions(+), 8 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index bebcb90..178def4 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -28,7 +28,7 @@ src_mmsd_SOURCES = $(gdbus_sources) $(gweb_sources) $(builtin_sources) \
> src/push.h src/push.c src/store.h src/store.c \
> src/wsputil.h src/wsputil.c src/mmsutil.h src/mmsutil.c
>
> -src_mmsd_LDADD = $(builtin_libadd) @GLIB_LIBS@ @DBUS_LIBS@ -lresolv -ldl
> +src_mmsd_LDADD = $(builtin_libadd) @GLIB_LIBS@ @DBUS_LIBS@
>
> src_mmsd_LDFLAGS = -Wl,--export-dynamic
>
> diff --git a/configure.ac b/configure.ac
> index d82569b..883b59c 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -64,15 +64,25 @@ dnl be different for different compiler flags (known issue on AIX)
> LT_INIT([dlopen,disable-static])
> AC_SUBST([LIBTOOL_DEPS])
>
> +dnl check how we can use the resolver. while resolv.h comes with bind,
> +dnl it's probably reasonable to use a combined search macro like
> +dnl smart-snmpd's ACX_CHECK_LIB_FLAGS
> AC_CHECK_HEADERS(resolv.h, dummy=yes,
> AC_MSG_ERROR(resolver header files are required))
> -AC_CHECK_LIB(resolv, ns_initparse, dummy=yes, [
> - AC_CHECK_LIB(resolv, __ns_initparse, dummy=yes,
> - AC_MSG_ERROR(resolver library support is required))
> -])
> -
> -AC_CHECK_LIB(dl, dlopen, dummy=yes,
> - AC_MSG_ERROR(dynamic linking loader is required))
> +dnl ns_initparse is libresolv internal use only - limited usage intended?
> +AC_SEARCH_LIBS(ns_initparse, resolv, ,
> + AC_MSG_ERROR(resolver support is required))
> +dnl AC_CHECK_LIB(resolv, ns_initparse, dummy=yes, [
> +dnl AC_CHECK_LIB(resolv, __ns_initparse, dummy=yes,
> +dnl AC_MSG_ERROR(resolver library support is required))
> +dnl ])
> +
> +dnl search how we can load dynamic libraries
> +dnl TODO use libltdl, which would work on BeOS (Haiku), Darwin (MacOS X) or
> +dnl for debugging purposes with libtool's dlpreopen
> +AC_SEARCH_LIBS(dlopen, dl, , AC_MSG_ERROR(dynamic linking loader is required))
> +dnl AC_CHECK_LIB(dl, dlopen, dummy=yes,
> +dnl AC_MSG_ERROR(dynamic linking loader is required))
what is this actually fixing. And all the dnl with dead code need to go
away.
Regards
Marcel
next prev parent reply other threads:[~2012-03-23 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 8:17 [PATCH 1/3] add some length verification to avoid reading not owned memory jr_extern
2012-02-28 8:17 ` [PATCH 2/3] changing depreciated libtool initialization to modern one jr_extern
2012-02-28 16:15 ` Jens Rehsack
2012-03-23 19:09 ` Marcel Holtmann
2012-02-28 8:17 ` [PATCH 3/3] let configure find required libs jr_extern
2012-03-23 19:11 ` Marcel Holtmann [this message]
2012-03-23 19:09 ` [PATCH 1/3] add some length verification to avoid reading not owned memory Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332529913.1870.60.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox