From: Mike Brudevold <puffy.taco@gmail.com>
To: ofono@ofono.org
Subject: [PATCH] voicecall: send CallRemoved for calls when voicecall atom is unregistered
Date: Wed, 18 Apr 2012 17:02:26 -0500 [thread overview]
Message-ID: <1334786546-4890-1-git-send-email-puffy.taco@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
From: Michael Brudevold <michael.brudevold@logicpd.com>
The CallRemoved signal was not being sent for existing calls when the voicecall
atom was unregistered. An example of this is the lack of a CallRemoved signal
when an HFP AG is disconnected due to SLC timeout while a call is active.
---
src/voicecall.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/voicecall.c b/src/voicecall.c
index 104b600..263f1ee 100644
--- a/src/voicecall.c
+++ b/src/voicecall.c
@@ -2699,8 +2699,11 @@ static void voicecall_unregister(struct ofono_atom *atom)
if (vc->dial_req)
dial_request_finish(vc);
- for (l = vc->call_list; l; l = l->next)
+ for (l = vc->call_list; l; l = l->next) {
+ voicecalls_emit_call_removed(vc, l->data);
+
voicecall_dbus_unregister(vc, l->data);
+ }
g_slist_free(vc->call_list);
vc->call_list = NULL;
--
1.7.5.4
next reply other threads:[~2012-04-18 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 22:02 Mike Brudevold [this message]
2012-04-18 15:52 ` [PATCH] voicecall: send CallRemoved for calls when voicecall atom is unregistered Denis Kenzior
2012-04-19 20:50 ` Mike
2012-04-19 14:02 ` Denis Kenzior
2012-04-20 13:36 ` Mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334786546-4890-1-git-send-email-puffy.taco@gmail.com \
--to=puffy.taco@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox