From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] voicecall: send CallRemoved for calls when voicecall atom is unregistered
Date: Thu, 19 Apr 2012 09:02:02 -0500 [thread overview]
Message-ID: <4F901ADA.8010808@gmail.com> (raw)
In-Reply-To: <CAB7rCThu4QsYXn+R9JTRSgfcP5xo1XffrBc0WsqFtOxDi4psLg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 555 bytes --]
Hi Mike,
>
> The only reason I added it is 4 hours of debugging my GUI and ofono to
> figure out why the GUI didn't notice the D-Bus path for the voice call
> was no longer around. The documentation for CallRemoved says "Signal
> that is sent when a voice call has been released." This implies it
> should be sent every time it is released. If you update the
> documentation to make it clear that this is not always the case, then
> it's fine by me.
>
Please check that commit 7f51df4d satisfies your requirements.
Regards,
-Denis
next prev parent reply other threads:[~2012-04-19 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 22:02 [PATCH] voicecall: send CallRemoved for calls when voicecall atom is unregistered Mike Brudevold
2012-04-18 15:52 ` Denis Kenzior
2012-04-19 20:50 ` Mike
2012-04-19 14:02 ` Denis Kenzior [this message]
2012-04-20 13:36 ` Mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F901ADA.8010808@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox