Re: [PATCH] util: Fix GSM to UTF8 conversion mechanism

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]

Hi Guillaume,

> >>>> + /*
> >>>> + * According to the 3GPP specifications 23.038
> >>>> + * section 6.2.1.1:
> >>>> + * In the case there is no character in the extension
> >>>> + * table, the character of the main default alphabet
> >>>> + * table or the character from the National Language
> >>>> + * Locking Shift Table should be displayed.
> >>>> + */
> >>>
> >>> What version of 23.038 are you using? I cannot find such wording in R9
> >>> or R10 specs.
> >>
> >> It is not the exact wording, I have just rephrased the comment.
> >> The exact wording it just below the GSM 7 bits default alphabet
> >> extension table in section 6.2.1.1
> >> Generally, do you prefer having an exact extract of the 3GPP spec or
> >> just an explanation of what is happening?
> >>
> >
> > The preference is to quote the spec verbatim and enclose the quote in 
> > "".  You can quote fragments of a sentence, etc.
> >
> > You can paraphrase, but I prefer that we only do that to distill 
> > something simple, e.g. maximum size of a structure/member.
> >
> 
> Ok, I keep his in mind for the next patches.

and can someone please run the unit tests if we are touching this:

/testutil/Invalid Conversions: **
ERROR:unit/test-util.c:362:test_invalid: assertion failed: (res == NULL)
Aborted (core dumped)

Regards

Marcel