From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] util: Fix GSM to UTF8 conversion mechanism
Date: Tue, 17 Jul 2012 13:14:17 -0500 [thread overview]
Message-ID: <5005AB79.20805@gmail.com> (raw)
In-Reply-To: <5006C01F.4050404@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
Hi Guillaume,
>> and can someone please run the unit tests if we are touching this:
>>
>> /testutil/Invalid Conversions: **
>> ERROR:unit/test-util.c:362:test_invalid: assertion failed: (res == NULL)
>> Aborted (core dumped)
>
> The purpose of this test was to check if we were failing to convert an
> invalid GSM extended character.
> As this was not the 3GPP recommended behavior, it sounds senseless to
> have it in test_invalid() now.
>
> Denis, should we modify it in checking the character of the main default
> alphabet is returned and add it in test_valid() section?
Yes, please update the tests.
Regards,
-Denis
next prev parent reply other threads:[~2012-07-17 18:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 14:34 [PATCH] util: Fix GSM to UTF8 conversion mechanism Guillaume Zajac
2012-07-16 0:49 ` Denis Kenzior
2012-07-17 8:41 ` Guillaume Zajac
2012-07-17 2:09 ` Denis Kenzior
2012-07-18 8:06 ` Guillaume Zajac
2012-07-18 12:31 ` Marcel Holtmann
2012-07-18 13:54 ` Guillaume Zajac
2012-07-17 18:14 ` Denis Kenzior [this message]
2012-07-17 3:53 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5005AB79.20805@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox