Open Source Telephony
 help / color / mirror / Atom feed
From: Anthony Viallard <viallard@syscom-instruments.com>
To: ofono@ofono.org
Subject: [PATCH 4/4] SIMCOM signal strength reporting quirk
Date: Fri, 22 Mar 2013 11:36:18 +0100	[thread overview]
Message-ID: <1363948578-24128-4-git-send-email-viallard@syscom-instruments.com> (raw)
In-Reply-To: <1363948578-24128-1-git-send-email-viallard@syscom-instruments.com>

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

Add a quirk for signal strength reporting.

We must tell we want the signal strength reporting using
AT+AUTOCSQ command (ref. SIM5215_SIM5216_ATC_V1.18.pdf - ��10.7).

diff -purN ofono-1.12/drivers/atmodem/network-registration.c ofono-patched/drivers/atmodem/network-registration.c
--- ofono-1.12/drivers/atmodem/network-registration.c	2013-01-18 15:04:03.598659165 +0100
+++ ofono-patched/drivers/atmodem/network-registration.c	2013-01-18 14:54:03.256659236 +0100
@@ -1411,6 +1411,14 @@ static void at_creg_set_cb(gboolean ok,
 	}
 
 	switch (nd->vendor) {
+	case OFONO_VENDOR_SIMCOM:
+		/* Register for CSQ changes */
+		g_at_chat_send(nd->chat, "AT+AUTOCSQ=1,1", none_prefix,
+				NULL, NULL, NULL);
+
+		g_at_chat_register(nd->chat, "+CSQ:",
+ 				   csq_notify, FALSE, netreg, NULL);
+ 		break;
 	case OFONO_VENDOR_PHONESIM:
 		g_at_chat_register(nd->chat, "+CSQ:",
 					csq_notify, FALSE, netreg, NULL);
@@ -1534,7 +1537,6 @@ static void at_creg_set_cb(gboolean ok,
 		break;
 	case OFONO_VENDOR_NOKIA:
 	case OFONO_VENDOR_SAMSUNG:
-	case OFONO_VENDOR_SIMCOM:
 		/* Signal strength reporting via CIND is not supported */
 		break;
 	default:


  parent reply	other threads:[~2013-03-22 10:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22 10:36 [PATCH 1/4] SIMCOM plugin driver Anthony Viallard
2013-03-22 10:36 ` [PATCH 2/4] SIMCOM AT+CNMI quirk Anthony Viallard
2013-04-02  2:35   ` Denis Kenzior
2013-03-22 10:36 ` [PATCH 3/4] SIMCOM SIM card ready quirk Anthony Viallard
2013-04-02  2:39   ` Denis Kenzior
2013-03-22 10:36 ` Anthony Viallard [this message]
2013-04-02  2:40   ` [PATCH 4/4] SIMCOM signal strength reporting quirk Denis Kenzior
2013-04-02  2:33 ` [PATCH 1/4] SIMCOM plugin driver Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363948578-24128-4-git-send-email-viallard@syscom-instruments.com \
    --to=viallard@syscom-instruments.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox