From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] SIMCOM AT+CNMI quirk
Date: Mon, 01 Apr 2013 21:35:44 -0500 [thread overview]
Message-ID: <515A4400.1030805@gmail.com> (raw)
In-Reply-To: <1363948578-24128-2-git-send-email-viallard@syscom-instruments.com>
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
Hi Anthony,
On 03/22/2013 05:36 AM, Anthony Viallard wrote:
> Add a quirk for AT+CNMI command building.
>
> Use mode=1 otherwise it fails (ref. SIM5215_SIM5216_ATC_V1.18.pdf - §6.9)
>
You might want to quote the relevant section in the patch description.
Otherwise it looks good to me, but I still can't apply it. Please use
git send-email.
> --- ofono-1.12.orig/drivers/atmodem/sms.c 2012-04-20 21:06:29.000000000 +0200
> +++ ofono-1.12/drivers/atmodem/sms.c 2013-01-21 16:48:44.460627485 +0100
> @@ -805,6 +807,7 @@ static gboolean build_cnmi_string(char *
> case OFONO_VENDOR_NOVATEL:
> case OFONO_VENDOR_HUAWEI:
> case OFONO_VENDOR_ZTE:
> + case OFONO_VENDOR_SIMCOM:
> /* MSM devices advertise support for mode 2, but return an
> * error if we attempt to actually use it. */
> mode = "1";
>
>
>
> _______________________________________________
> ofono mailing list
> ofono(a)ofono.org
> http://lists.ofono.org/listinfo/ofono
Regards,
-Denis
next prev parent reply other threads:[~2013-04-02 2:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 10:36 [PATCH 1/4] SIMCOM plugin driver Anthony Viallard
2013-03-22 10:36 ` [PATCH 2/4] SIMCOM AT+CNMI quirk Anthony Viallard
2013-04-02 2:35 ` Denis Kenzior [this message]
2013-03-22 10:36 ` [PATCH 3/4] SIMCOM SIM card ready quirk Anthony Viallard
2013-04-02 2:39 ` Denis Kenzior
2013-03-22 10:36 ` [PATCH 4/4] SIMCOM signal strength reporting quirk Anthony Viallard
2013-04-02 2:40 ` Denis Kenzior
2013-04-02 2:33 ` [PATCH 1/4] SIMCOM plugin driver Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515A4400.1030805@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox