(no subject)

[Li, Minjun]

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

Hi Folks,
I have made a patch for minor bugs in functions of dial_callback and voicecall_busy in /src/voicecall.c.

Best Regards,
Minjun


[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 2333 bytes --]

[-- Attachment #3: 0001-minor-bug-in-dial_callback-and-voicecall_busy.patch --]
[-- Type: application/octet-stream, Size: 1081 bytes --]

From 852e53593070dd0346a7385a62a10c1c0946b5c0 Mon Sep 17 00:00:00 2001
From: root <root@minjun.localdomain>
Date: Tue, 26 May 2009 08:48:57 +0800
Subject: [PATCH] minor bug in dial_callback and voicecall_busy

---
 src/voicecall.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/voicecall.c b/src/voicecall.c
index bbc7bf5..8318143 100644
--- a/src/voicecall.c
+++ b/src/voicecall.c
@@ -198,7 +198,7 @@ static DBusMessage *voicecall_busy(DBusConnection *conn,
 		call->status != CALL_STATUS_WAITING)
 		return dbus_gsm_failed(msg);
 
-	if (!voicecalls->ops->release_specific)
+	if (!voicecalls->ops->set_udub)
 		return dbus_gsm_not_implemented(msg);
 
 	if (voicecalls->flags & VOICECALLS_FLAG_PENDING)
@@ -1444,7 +1444,7 @@ static void dial_callback(const struct ofono_error *error, void *data)
 		}
 
 		ofono_debug("Registering new call: %d", call->id);
-		voicecall_dbus_register(voicecall_create(modem, call));
+		voicecall_dbus_register(v);
 
 		calls->call_list = g_slist_insert_sorted(calls->call_list, v,
 					call_compare);
-- 
1.6.0.3

Re:

[Leandro Dorileo]

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

Hi Minjun

On Tue, May 26, 2009 at 9:56 PM, Li, Minjun <minjun.li@intel.com> wrote:
> Hi Folks,
>
> I have made a patch for minor bugs in functions of dial_callback and
> voicecall_busy in /src/voicecall.c.

Could you provide us with more detailed informations about the bugs
you're supposed to fix with your patch?

Reviewing you patch I found you changed the behavior of the original
code, touching that part of code you can even have made the bug
"disapeared" but not fixed the bug you discovered.

regards...

-- 
(°=   Leandro Dorileo
//\    ldorileo(a)gmail.com   -   http://www.dorilex.net
V_/  Software is a matter of freedom.

Re:

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi Minjun,

On Tuesday 26 May 2009 19:56:31 Li, Minjun wrote:
> Hi Folks,
> I have made a patch for minor bugs in functions of dial_callback and
> voicecall_busy in /src/voicecall.c.

Can you separate this into two patches.  And make sure your git user email and 
name is properly set.  I will not accept patches from root(a)foobar (e.g. root 
<root@minjun.localdomain> in your case)

Regards,
-Denis

Re:

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Hi Minjun,

> 
> I have made a patch for minor bugs in functions of dial_callback and
> voicecall_busy in /src/voicecall.c.

some rules for using this mailing list. No HTML emails. Just use plain
ASCII based email.

For the patches. One patch per logical fix and please write commit
messages that describe what you are doing.

Things like "minor bug" sound like you are introducing a bug. Describe
briefly the thing that you are fixing. If it is more complicated or not
obvious, add additional details in the commit message.

Commit messages should not exceed 70-72 characters per line btw.

Regards

Marcel

(no subject)

[=?unknown-8bit?q?Jo=C3=A3o?= Paulo Rechi Vita]

[-- Attachment #1: Type: text/plain, Size: 117 bytes --]


Changed sim_state to an enum type and removed an extra check which was causing
issues with pin-locked sim cards.

Re:

[=?unknown-8bit?q?Jo=C3=A3o?= Paulo Rechi Vita]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

2010/8/5 João Paulo Rechi Vita <jprvita@profusion.mobi>:
>
> Changed sim_state to an enum type and removed an extra check which was causing
> issues with pin-locked sim cards.

Sorry, I've messed up a bit with git-send-email. This comment is
regarding the reviewed version of "[PATCH] huawei: Fix SIM state
logic".

-- 
João Paulo Rechi Vita
http://jprvita.wordpress.com/

(no subject)

[Miettinen Pasi]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

Hi all,

Starting on Monday, I am taking another assignment and I am unable
to contribute further. From our side, Petteri Tikander continues to work
on the SMS delivery report task.

Regards,
Pasi Miettinen

Re:

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

Hi Pasi,

> Hi all,
> 
> Starting on Monday, I am taking another assignment and I am unable
> to contribute further. From our side, Petteri Tikander continues to work
> on the SMS delivery report task.

Sorry to hear that, good luck with the next assignment.  Could you have 
Petteri officially take ownership of this task?

Thanks,
-Denis

Re:

[^_^]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

i apologies for that but i hope u could at least poke in from time to time
at least to have some minor input. I hope you enjoy whatever other
assignment you get... ^_^ good luck!

-

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 192 bytes --]

(no subject)

[krishna k]

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]


Hi Yoon,

Thank very much for your guidance. I followed the same procedure ...

You already did following procedure.
1. ofono-phonesim -p 12345 -gui ~/data/moblin.xml
2. sudo ofonod -nd 

And then, you need to type following command to power up modem(phonesim).
3. dbus-send --system --print-reply --dest=org.ofono / phonesim0 org.ofono.Modem.SetProperty string:Powered variant:boolean:true
I got below response....

Must use org.mydomain.Interface.Method notation, no dot in "phonesim0"

Please see the ps ax | grep ofono*
-------------------------------------------------------------------------------------------------------------------------
 1609 pts/0    S+     0:00 ofono-phonesim -p 12345 -gui /home/kandukis/data/moblin.xml
 1654 pts/2    S+     0:00 ofonod -nd
------------------------------------------------------------------------------------------------------------------------

Can you please suggest  how to get-rid from this problem.

regards,
Krishna K Kandula


 		 	   		  
_________________________________________________________________
South Cinema This Decade
http://entertainment.in.msn.com/southcinemathisdecade/

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 1541 bytes --]

Re:

[Dario]

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

Hi krishna,
> Hi Yoon,
>
> Thank very much for your guidance. I followed the same procedure ...
>
> You already did following procedure.
> 1. ofono-phonesim -p 12345 -gui ~/data/moblin.xml
> 2. sudo ofonod -nd 
>
> And then, you need to type following command to power up modem(phonesim).
> 3. dbus-send --system --print-reply --dest=org.ofono / phonesim0 org.ofono.Modem.SetProperty string:Powered variant:boolean:true
>   
> I got below response....
>
> *Must use org.mydomain.Interface.Method notation, no dot in "phonesim0"*
It seems you wrote the command with a bad syntax, there shoudn't be any 
white space between / and phonesim0, the command is:

dbus-send --system --print-reply --dest=org.ofono /phonesim0 
org.ofono.Modem.SetProperty string:'Powered' variant:boolean:true

(I suggest using quotes rounding string constants).

Bye,
Dario.


[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 1404 bytes --]

(no subject)

[sudishm m]

[-- Attachment #1: Type: text/plain, Size: 113 bytes --]

Hi,

how do I donload the source code, to my PC and build it.Please provide
instructions to do so,

Sudish

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 164 bytes --]

Re:

[Leandro Dorileo]

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

Hi

On Thu, May 21, 2009 at 2:31 AM, sudishm m <sudimenon@gmail.com> wrote:
> Hi,
>
> how do I donload the source code, to my PC and build it.Please provide
> instructions to do so,

You can find instructions in the project`s website[1]. All you need is
to clone the git repository[2]. Here[3] you find out more instructions
about git.


[1] - http://ofono.org/downloads
[2] - git://git.kernel.org/pub/scm/network/ofono/ofono.git
[3] - http://git-scm.com/

Regards...

-- 
(°=   Leandro Dorileo
//\    ldorileo(a)gmail.com   -   http://www.dorilex.net
V_/  Software is a matter of freedom.