From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] Add GAtServer basic parsing support
Date: Thu, 14 Jan 2010 14:57:43 -0600 [thread overview]
Message-ID: <201001141457.43301.denkenz@gmail.com> (raw)
In-Reply-To: <1263505988.5591.21.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
Hi Marcel,
> Hi Denis,
>
> > > +#include "gatserver.h"
> > > +
> > > +#define DBG(fmt, arg...) g_print("%s:%s() " fmt, __FILE__,
> > > __FUNCTION__ , ## arg) +
> >
> > Move this to gat.h
>
> can we actually not be using DBG inside gatchat. Why is that suddenly
> needed?
Actually good point. I agree this should be removed.
Regards,
-Denis
next prev parent reply other threads:[~2010-01-14 20:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 10:53 [PATCH 1/4] Add gatutil.c to share common APIs with GAtServer Zhenhua Zhang
2010-01-11 10:53 ` [PATCH 2/4] Add GAtServer basic parsing support Zhenhua Zhang
2010-01-11 10:53 ` [PATCH 3/4] Add AT command parsing support and interface Zhenhua Zhang
2010-01-11 10:53 ` [PATCH 4/4] Add test-server test application for GAtServer Zhenhua Zhang
2010-01-14 17:24 ` [PATCH 2/4] Add GAtServer basic parsing support Denis Kenzior
2010-01-14 21:53 ` Marcel Holtmann
2010-01-14 20:57 ` Denis Kenzior [this message]
2010-01-14 15:49 ` [PATCH 1/4] Add gatutil.c to share common APIs with GAtServer Denis Kenzior
2010-01-15 1:24 ` Zhang, Zhenhua
2010-01-20 20:23 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001141457.43301.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox