From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/4] Add gatutil.c to share common APIs with GAtServer
Date: Wed, 20 Jan 2010 14:23:18 -0600 [thread overview]
Message-ID: <201001201423.19179.denkenz@gmail.com> (raw)
In-Reply-To: <8B81FACE836F9248894A7844CC0BA8141C433BF03A@shzsmsx501.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
Hi Zhenhua,
> Hi Denis,
>
> Denis Kenzior wrote:
> > Hi Zhenhua,
> >
> >> +gboolean g_at_util_set_io(GIOChannel *io)
> >
> > Rename this g_at_util_setup_io
> >
> >> +typedef void (*GAtDisconnectFunc)(gpointer user_data); typedef void
> >> +(*GAtDebugFunc)(const char *str, gpointer user_data);
> >
> > These don't belong here, create a new file called gat.h and put them
> > there.
> >
> > Regards,
> > -Denis
>
> Thanks for your comments. Updated patch is attached.
>
Patch has been applied. Thanks.
Regards,
-Denis
prev parent reply other threads:[~2010-01-20 20:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 10:53 [PATCH 1/4] Add gatutil.c to share common APIs with GAtServer Zhenhua Zhang
2010-01-11 10:53 ` [PATCH 2/4] Add GAtServer basic parsing support Zhenhua Zhang
2010-01-11 10:53 ` [PATCH 3/4] Add AT command parsing support and interface Zhenhua Zhang
2010-01-11 10:53 ` [PATCH 4/4] Add test-server test application for GAtServer Zhenhua Zhang
2010-01-14 17:24 ` [PATCH 2/4] Add GAtServer basic parsing support Denis Kenzior
2010-01-14 21:53 ` Marcel Holtmann
2010-01-14 20:57 ` Denis Kenzior
2010-01-14 15:49 ` [PATCH 1/4] Add gatutil.c to share common APIs with GAtServer Denis Kenzior
2010-01-15 1:24 ` Zhang, Zhenhua
2010-01-20 20:23 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001201423.19179.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox