Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] Remove dead assignments at gatchat
Date: Tue, 02 Feb 2010 16:32:16 -0600	[thread overview]
Message-ID: <201002021632.17042.denkenz@gmail.com> (raw)
In-Reply-To: <1265148510-24408-2-git-send-email-padovan@profusion.mobi>

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Hi Gustavo,

> ---
>  gatchat/gatchat.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)

So I applied this patch with one minor change:
 
> @@ -753,7 +751,7 @@ static void wakeup_cb(gboolean ok, GAtResult *result,
>  gpointer user_data) static gboolean wakeup_no_response(gpointer user)
>  {
>  	GAtChat *chat = user;
> -	struct at_command *cmd = g_queue_peek_head(chat->command_queue);
> +	struct at_command *cmd;

This part was no longer necessary.

Regards,
-Denis

  reply	other threads:[~2010-02-02 22:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-02 22:08 [PATCH 1/2] Fix use of uninitialized variable Gustavo F. Padovan
2010-02-02 22:08 ` [PATCH 2/2] Remove dead assignments at gatchat Gustavo F. Padovan
2010-02-02 22:32   ` Denis Kenzior [this message]
2010-02-02 22:33 ` [PATCH 1/2] Fix use of uninitialized variable Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201002021632.17042.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox