From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/2] Fix use of uninitialized variable
Date: Tue, 02 Feb 2010 16:33:07 -0600 [thread overview]
Message-ID: <201002021633.07612.denkenz@gmail.com> (raw)
In-Reply-To: <1265148510-24408-1-git-send-email-padovan@profusion.mobi>
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
Hi Gustavo,
> ---
> gatchat/gatchat.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c
> index e25bfd6..5b0851b 100644
> --- a/gatchat/gatchat.c
> +++ b/gatchat/gatchat.c
> @@ -692,7 +692,7 @@ static gboolean received_data(GIOChannel *channel,
> GIOCondition cond, unsigned char *buf;
> GAtChat *chat = data;
> GIOError err;
> - gsize rbytes;
> + gsize rbytes = 0;
> gsize toread;
> gsize total_read = 0;
> guint read_count = 0;
>
I'm convinced that this is a false positive. The read_count keeps rbytes from
ever being referenced when undefined.
Regards,
-Denis
prev parent reply other threads:[~2010-02-02 22:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 22:08 [PATCH 1/2] Fix use of uninitialized variable Gustavo F. Padovan
2010-02-02 22:08 ` [PATCH 2/2] Remove dead assignments at gatchat Gustavo F. Padovan
2010-02-02 22:32 ` Denis Kenzior
2010-02-02 22:33 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002021633.07612.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox