[PATCH] Fix: clean-local target

[PATCH] Fix: clean-local target

[Pekka Pessi]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

---
 Makefile.am |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 86ccf1b..db7e33e 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -426,5 +426,5 @@ include/ofono/%.h: include/%.h
 	$(AM_V_at)$(MKDIR_P) include/ofono
 	$(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
 
-clean-local: include/ofono
-	@$(RM) -r $<
+clean-local:
+	$(RM) -rf include/ofono
-- 
1.6.3.3

Re: [PATCH] Fix: clean-local target

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

Hi Pekka,

>  Makefile.am |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 86ccf1b..db7e33e 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -426,5 +426,5 @@ include/ofono/%.h: include/%.h
>  	$(AM_V_at)$(MKDIR_P) include/ofono
>  	$(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
>  
> -clean-local: include/ofono
> -	@$(RM) -r $<
> +clean-local:
> +	$(RM) -rf include/ofono

what is this trying to fix?

And you removed the @ in front of the command.

Regards

Marcel

Re: [PATCH] Fix: clean-local target

[=?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont]

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

Le vendredi 23 avril 2010 19:25:18 Marcel Holtmann, vous avez écrit :
> Hi Pekka,
> 
> >  Makefile.am |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile.am b/Makefile.am
> > index 86ccf1b..db7e33e 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -426,5 +426,5 @@ include/ofono/%.h: include/%.h
> >  	$(AM_V_at)$(MKDIR_P) include/ofono
> >  	$(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
> >
> > -clean-local: include/ofono
> > -	@$(RM) -r $<
> > +clean-local:
> > +	$(RM) -rf include/ofono
> 
> what is this trying to fix?

Not -pointlessly- build include/ofono just before removing it.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis

Re: [PATCH] Fix: clean-local target

[Pekka Pessi]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

2010/4/23 Marcel Holtmann <marcel@holtmann.org>:
>> @@ -426,5 +426,5 @@ include/ofono/%.h: include/%.h
>> -clean-local: include/ofono
>> -     @$(RM) -r $<
>> +clean-local:
>> +     $(RM) -rf include/ofono
>
> what is this trying to fix?

An error happening if you do make clean twice, or distclean followed
by clean. I have no idea what the original construct is trying to
achieve.

> And you removed the @ in front of the command.

I removed @ so it is consistent with Automake's clean rules. Other rm
commands are shown when you say make clean.

-- 
Pekka.Pessi mail at nokia.com